Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockFactory may not be initialized when a LightPopulationTask is run #2488

Closed
dktapps opened this issue Oct 22, 2018 · 1 comment
Closed
Labels
Category: Core Related to internal functionality Resolution: Fixed

Comments

@dktapps
Copy link
Member

dktapps commented Oct 22, 2018

Issue description

Since the changes to make the generator not be initialized until needed now, LightPopulationTask may silently produce wrong results due to the BlockFactory not being initialized, since it previously allowed GeneratorRegisterTask to do this on its behalf. This was not noticed until now because PHP doesn't mind doing array access on null variables and doesn't bother to warn about it.

Steps to reproduce the issue

  1. have a world with no light saved
  2. load some chunks without generating chunks prior
@dktapps dktapps added Category: Core Related to internal functionality Status: Debugged Cause of the bug has been found, but not fixed labels Oct 22, 2018
@buchwasa
Copy link
Contributor

oof

@dktapps dktapps added Resolution: Fixed and removed Status: Debugged Cause of the bug has been found, but not fixed labels Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core Related to internal functionality Resolution: Fixed
Projects
None yet
Development

No branches or pull requests

2 participants