Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename World::getSpawnLocation to World::getSpawnPosition #3829

Open
inxomnyaa opened this issue Sep 19, 2020 · 1 comment
Open

Rename World::getSpawnLocation to World::getSpawnPosition #3829

inxomnyaa opened this issue Sep 19, 2020 · 1 comment
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Inconsistency Related to an inconsistency in the API, behaviour, ...

Comments

@inxomnyaa
Copy link
Contributor

inxomnyaa commented Sep 19, 2020 •
edited

Rename World::getSpawnLocation to World::getSpawnPosition to make it consistent with what the function returns - Position.

Description

I am on PM4, just to remove confusion

Justification

Add additional getSpawnLocation method?

Alternative methods

return Location::fromObject($position->asVector3(), $position->world);
@ghost

This comment was marked as spam.

Sign in to view
@dktapps dktapps added BC break Breaks API compatibility Category: API Related to the plugin API Inconsistency Related to an inconsistency in the API, behaviour, ... labels Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BC break Breaks API compatibility Category: API Related to the plugin API Inconsistency Related to an inconsistency in the API, behaviour, ...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inxomnyaa @dktapps