-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heightfields with negative values will fire face normal errors #45
Comments
The failure to collide might just be due to lack of CCD, not a heightfield issue. Removing that part of the issue (though still a big issue). |
I found the issue, which stems from the convex triangle pillar being upside down when the heightfield has a negative value. Will send a PR in the next few minutes. |
Awesome, great work digging in and hunting down the issue. I'll cut a quick release with your fix. |
I've published a new version of cannon-es with the fix to heightfields |
Awesome, thanks for being so responsive. |
Absolutely, we welcome any further contributions 👍 |
To reproduce, change all heightfield data points in the
heightfield.html
demo to -5. You will see 1,000+ errors thrown fromConvexPolyhedron
when computing convex triangle pillars.This was also an issue from 2014: schteppe#149
The text was updated successfully, but these errors were encountered: