Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LensDistortionEffect #592

Closed
3 tasks done
Tracked by #600
vanruesc opened this issue Feb 16, 2024 · 4 comments
Closed
3 tasks done
Tracked by #600

Implement LensDistortionEffect #592

vanruesc opened this issue Feb 16, 2024 · 4 comments
Assignees
@seralichtenhahn
Labels
feature Description for the implementation of a feature
Milestone
v7

Comments

@vanruesc
Copy link
Member

vanruesc commented Feb 16, 2024 •
edited
Loading

Description

Implement a LensDistortionEffect.

Tasks

  • Create LensDistortionEffect.
  • Create lens-distortion demo.
  • Add unit test.

Implementation Details

  • The implementation from v6 can be copied mostly as-is.
@vanruesc vanruesc added the feature Description for the implementation of a feature label Feb 16, 2024
@vanruesc vanruesc added this to the v7 milestone Feb 16, 2024
@vanruesc vanruesc mentioned this issue Feb 17, 2024
Open
31 tasks
@seralichtenhahn
Copy link

@vanruesc I can work on this!

@vanruesc
Copy link
Member Author

Ok, thanks!

@seralichtenhahn seralichtenhahn mentioned this issue Apr 21, 2024
Merged
@seralichtenhahn
Copy link

Thanks @vanruesc 🙏

I opened a PR with the implementation (#627). I'd love to hear your thoughts.

@vanruesc
Copy link
Member Author

Nice, I'll take a look when I get a chance.

@vanruesc vanruesc closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seralichtenhahn seralichtenhahn

Labels
feature Description for the implementation of a feature
Projects
None yet
Milestone
v7
Development

No branches or pull requests
2 participants
@vanruesc @seralichtenhahn