Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leaderboards #106

Merged
merged 7 commits into from Jun 10, 2021
Merged

Add leaderboards #106

merged 7 commits into from Jun 10, 2021

Conversation

SaraVieira
Copy link
Member

@SaraVieira SaraVieira commented Jun 10, 2021

  • Checks if you already set a name, if not asks you a name and saves it in localstorage
  • Adds you to the leaderboard
  • Shows the number you are

Issues:

  • Restart does not work idk why

@vercel
Copy link

vercel bot commented Jun 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/racing-game/ssNpGDeK5rY9rcjTf7rQ96b3Ao56
✅ Preview: https://racing-game-git-leaderboards-pmndrs.vercel.app

@Gusted
Copy link
Contributor

Gusted commented Jun 10, 2021

This conflicting with #99

@SaraVieira
Copy link
Member Author

yeah, I don't know what to do about that, I talked to paul about making this yesterday and noticed that came in when I was almost done

@Gusted
Copy link
Contributor

Gusted commented Jun 10, 2021

Maybe time to open up issues to track features and make sure not 2 people are working on the same thing.

@njm222
Copy link
Member

njm222 commented Jun 10, 2021

My bad I didn't know you were working on it too. I can look into the issues in a bit, pretty sure I resolved the first one already.

@SaraVieira
Copy link
Member Author

Im super sorry too, did not want to step on anyone's toes :(

The env thing is fixed

@njm222
Copy link
Member

njm222 commented Jun 10, 2021

No worries :) I'm just glad it's almost done

@SaraVieira
Copy link
Member Author

Definiutly do think we can use your PR and add auth in the future

@njm222
Copy link
Member

njm222 commented Jun 10, 2021

Yeah I can merge it in afterwards! (Looking into the restart issue now)

@SaraVieira SaraVieira requested review from drcmda and njm222 June 10, 2021 13:24
Copy link
Member

@drcmda drcmda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very happy with this. 🎉 @njm222 you found the restart problem? i think it can go in then. and like you said, we can merge your auth part afterwards. thank you @SaraVieira !

@drcmda drcmda marked this pull request as ready for review June 10, 2021 14:34
@drcmda drcmda merged commit 26df7b1 into main Jun 10, 2021
import { createClient } from '@supabase/supabase-js'
import { useState } from 'react'

export const supabase = createClient(import.meta.env['VITE_SUPABASE_URL'], import.meta.env['VITE_SUPABASE_ANON_KEY'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for now.. I'll extract this out when I merge auth

@njm222 njm222 deleted the leaderboards branch June 10, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants