Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication #115

Merged
merged 15 commits into from Jun 13, 2021
Merged

Authentication #115

merged 15 commits into from Jun 13, 2021

Conversation

njm222
Copy link
Member

@njm222 njm222 commented Jun 12, 2021

Added oAuth authentication with github & google

@SaraVieira You will need to turn on google as a provider & restrict the scores routes to authenticated only

@vercel
Copy link

vercel bot commented Jun 12, 2021

@njm222 is attempting to deploy a commit to the Poimandres Team on Vercel.

A member of the Team first needs to authorize it.

@njm222 njm222 requested review from SaraVieira and drcmda June 12, 2021 06:51
src/ui/Finished.jsx Outdated Show resolved Hide resolved
src/ui/Auth.jsx Outdated Show resolved Hide resolved
Co-authored-by: Bjorn Stromberg <bjorn@bjornstar.com>
@vercel
Copy link

vercel bot commented Jun 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/racing-game/3FBY2Kj3hNtSmRgxFAR4egsQTy2j
✅ Preview: https://racing-game-git-fork-njm222-auth-pmndrs.vercel.app

@drcmda
Copy link
Member

drcmda commented Jun 12, 2021

are we finished here @njm222 ? anything that needs to done before we merge?

@njm222
Copy link
Member Author

njm222 commented Jun 13, 2021

Yes it is ready to go! I think Sara still needs to turn on google as a provider and restrict the routes but it can be merged without those changes

src/data.js Outdated Show resolved Hide resolved
@njm222
Copy link
Member Author

njm222 commented Jun 13, 2021

Good to go! (merged in main and fixed a minor issue)

@drcmda drcmda merged commit 9227c6a into pmndrs:main Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants