New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File structure #71
Comments
i think its quite common. components captitalized, everything else lowercase. index.js. Minimap.js everything either lower or uppercase and .jsx seems not so common to me, at least none of the clis do it. |
Hmm okay |
btw i found this: https://reactjs.org/docs/faq-structure.html react ofc is unopinionated but these suggestions are what i see most people using. |
We already had an issue with filename capitalization because git does not pick up capitalization changes by default. Some filesystems are case insensitive and didn't have an issue, while others are case sensitive and the build broke. We can avoid problems with capitalization if we standardize on lowercase. I also agree that |
if we use jsx, then i think we could move to vite. craco + esbuild is faster than cra, but vite is up without any delay, 0.01ms, also fast refresh is instant. but i think it wants "jsx" which i thought is weird that's why i chose cra initially. @bjornstar @Gusted should we? |
I've heard of Vite and seen it a couple of times being used. It's more tooling than CRA offers at this moment and seems like they already have a template for react however if we for some reason want's to switch to Ts in the future it's better to do it now and use the typescript react template. Vite overall seems great no issues raised from me. Additionally we could covert this into a discussion, to get some more input. |
I don't mind trying |
Now everyone has their own taste about how to structure files, however at this moment I see 2 problems.
.js
files, I think they should be renamed to the correct file extension ->.jsx
The text was updated successfully, but these errors were encountered: