Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression #77

Closed
Gusted opened this issue Jun 7, 2021 · 14 comments
Closed

Regression #77

Gusted opened this issue Jun 7, 2021 · 14 comments

Comments

@Gusted
Copy link
Contributor

Gusted commented Jun 7, 2021

Since commit: b604d2b

I've been experince(firefox-only) a regression whereby the camera is heavily shaking.

Please ignore the happering/stuttering, this is due to Nvidia, fuck you propriety drivers on Linux with Firefox.
https://user-images.githubusercontent.com/25481501/121050841-72d61d00-c7a8-11eb-8fef-8dd672a362a0.mp4

@Gusted Gusted changed the title Camera regression Regression Jun 7, 2021
@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

latest build as well? and firefox only? that is very strange. i need to install it ..

@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

my suspicion is that this is because of lerp(..., delta) and ff handling delta weird? i started to lerp the steering bc it was immediate before (press left/right and the wheel just "pops" into place). i was told that using delta in lerp is correct because of different device refresh rates but could you try 0.1 everywhere it says "delta" just to see if that's the issue?

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

latest build as well?

Yep!

and firefox only?

yes... But after getting ungoogled chromium to force the same stuttering as firefox by adjusting the gpu flags I was hit by an even greater issue of the whole car seems to be clipping trough the ground - Better said the car was in the ground and trying to move around. But once this stuttering doesn't occur it works completely fine.

i was told that using delta in lerp is correct because of different device refresh rates

The refresh rate of webgl or something related? Or the rAF function?

0.1 everywhere it says "delta" just to see if that's the issue?

Highly reduces the shaking/stuttering of the vehicle but physics are broken so could be just that but definitely a difference.

@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

i did push a fix to use-cannon today due to another perf refression i hope its not related
could you try the delta -> 0.1 "fix" can the previous use-cannon?

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

i did push a fix to use-cannon today due to another perf refression i hope its not related
could you try the delta -> 0.1 "fix" can the previous use-cannon?

Did you mean this update to use-cannon? b604d2b#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R14

If so. The commit before a3fdf54 works totally fine even without the delta fix.

@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

so the update to use-cannon is messing it up. if you just change the version back, is it ok? not at my computer rn to check.

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

if you just change the version back, is it ok?

image
Doing a yarn install and yarn run dev and nope. Same behavior so you can exclude those packages as faulty 😄.

@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

that's a relief. i try to debug against the race-condition pr you've outlined, must be in there.

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

i try to debug against the race-condition

You mean this commit? b604d2b
After that the commit the strange behavior is appearing the race conditions commit(a3fdf54) is good and doesn't cause this behavior.

@drcmda
Copy link
Member

drcmda commented Jun 7, 2021

so i cant repro that crazy shaking behaviour just the occasional frameskip in ff (macos) which is bad enough. but i went back to a3fdf54 and i get the same lag so i think that's just how ff runs webgl.

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

Ill try to be looking into it myself, this is probably going to take some hours and end up with 1 little chance to fix this as every weird bug does.

@njm222
Copy link
Member

njm222 commented Jun 7, 2021

Yeah ff is quite bad with webgl

@Gusted
Copy link
Contributor Author

Gusted commented Jun 7, 2021

Yeah ff is quite bad with webgl

They had some good progress on Windows + Mac, but from what I've seen following the issue trackers around the webgl, Linux is a dead end with Nvidia, because they don't have certain functionality/extensions just for linux drivers. It's very limited case this one FF + Linux + Nvidia so shouldn't be that much troubling for general users.

@Gusted
Copy link
Contributor Author

Gusted commented Jun 10, 2021

I'd fucked up some about:config stuff. To anyone coming to this issue, make sure to not have any debugging enabled about the GPU. It will slow you down and cause weird weird behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants