Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Promise returned by Controller.start is not resolved consistently #2208

Open
1 of 5 tasks
yifeiyin opened this issue Oct 3, 2023 · 0 comments
Open
1 of 5 tasks
Labels
template: bug This issue might be a bug

Comments

@yifeiyin
Copy link

yifeiyin commented Oct 3, 2023

Which react-spring target are you using?

  • @react-spring/web
  • @react-spring/three
  • @react-spring/native
  • @react-spring/konva
  • @react-spring/zdog

What version of react-spring are you using?

9.7.3

What's Wrong?

await controller.start({ ... }) is not being resolved consistently. And the behaviour the consistently dependent on the animated value.

To Reproduce

  1. Open the codesandbox console
  2. click add 3 times
  3. click on the top left element to trigger removal
  4. click on the top element to trigger removal
  5. notice that the Finished awaiting never gets printed
  6. Go to line 74. Comment line 74. Uncomment line 76
  7. Reload page. Repeat 1-4. Notice that the finished awaiting gets printed

Expected Behaviour

Promise is always resolved immediately after animation completes.

Link to repo

https://codesandbox.io/s/react-spring-reproduce-s7jvwv

@yifeiyin yifeiyin added the template: bug This issue might be a bug label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
template: bug This issue might be a bug
Projects
None yet
Development

No branches or pull requests

1 participant