Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-spring compatibility #8

Open
giulioz opened this issue Aug 29, 2020 · 2 comments · May be fixed by #65
Open

React-spring compatibility #8

giulioz opened this issue Aug 29, 2020 · 2 comments · May be fixed by #65
Labels
enhancement New feature or request

Comments

@giulioz
Copy link
Member

giulioz commented Aug 29, 2020

We should add some examples and investigate how to integrate them nicely with the reflow

@giulioz giulioz added the enhancement New feature or request label Aug 29, 2020
@promontis
Copy link

I would also love to see some examples 🤗

@bbohlender
Copy link
Contributor

I think the best way for a react-spring integration would be a decoupling between r3f/flex and three where

      group.position.copy(position)

is set. If instead of setting the position directly, the Box-Element can pass a callback that is saved to the boxRefs, which can still just set the position or use a spring to change the position or execute any other function.
This would enable much more control over when and why an element is repositioned while still persisting the current functionality.

I would love to hear your thoughts, and I would also offer to implement this as a PR and make an example 😃

@bbohlender bbohlender linked a pull request Sep 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants