Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onCreated prop on the VRCanvas prevent 'ENTERVR' from displaying #65

Closed
AlaricBaraou opened this issue Jul 5, 2021 · 2 comments · Fixed by #66
Closed

onCreated prop on the VRCanvas prevent 'ENTERVR' from displaying #65

AlaricBaraou opened this issue Jul 5, 2021 · 2 comments · Fixed by #66

Comments

@AlaricBaraou
Copy link
Contributor

It's pretty straighforward

<VRCanvas
      onCreated={({ camera }) => camera.lookAt(0, 2, -2)} // having this prop prevent react-xr from working properly
>

having this prop prevent react-xr from working properly.
Because I guess it conflicts with this file
https://github.com/pmndrs/react-xr/blob/master/src/XR.tsx#L164
@CodyJasonBennett CodyJasonBennett mentioned this issue Jul 5, 2021
Merged
@m0o0scar
Copy link

m0o0scar commented Sep 5, 2021

I'm encountering the same issue, any update here?

@sniok sniok closed this as completed in #66 Sep 5, 2021
@sniok
Copy link
Member

sniok commented Sep 5, 2021

#66 will fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent overwriting XRCanvas bindings CodyJasonBennett/react-xr
3 participants
@m0o0scar @sniok @AlaricBaraou