Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotations should be Quaternions #10

Closed
nevernotsean opened this issue Mar 6, 2020 · 2 comments
Closed

Rotations should be Quaternions #10

nevernotsean opened this issue Mar 6, 2020 · 2 comments
Assignees
@drcmda @nevernotsean
Labels
bug Something isn't working

Comments

@nevernotsean
Copy link
Contributor

Cannon bodies use Quaternions instead of .rotation
@nevernotsean nevernotsean added the bug Something isn't working label Mar 6, 2020
@nevernotsean nevernotsean self-assigned this Mar 6, 2020
@nevernotsean
Copy link
Contributor Author

I've updated master with a fix. I'll be making future changes within a fork and start doing proper pull requests

@drcmda
Copy link
Member

drcmda commented Mar 6, 2020

i think for now its fine, if we feel we have a stable api we can also lock it so all commits go through review first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drcmda drcmda

@nevernotsean nevernotsean

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drcmda @nevernotsean