Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(middleware/persist): using new storage option with createJSONStorage causes subscription to fire early (regression) #1517

Closed
1 task done
meypod opened this issue Jan 9, 2023 · 0 comments · Fixed by #1518
Closed
1 task done

bug(middleware/persist): using new storage option with createJSONStorage causes subscription to fire early (regression) #1517

meypod opened this issue Jan 9, 2023 · 0 comments · Fixed by #1518

Comments

@meypod
Copy link

meypod commented Jan 9, 2023 •
edited

Summary

using old getStorage option would not fire subscriptions when retrieving the state from storage for the first time, but storage does

Link to reproduction

old: https://codesandbox.io/s/autumn-fog-400vf4
new: https://codesandbox.io/s/happy-carson-0teelt

Check List

  • I've already opened a discussion before opening this issue.
@meypod meypod changed the title bug(middleware/persist): using new storage option with createJSONStorage causes subscription to fire bug(middleware/persist): using new storage option with createJSONStorage causes subscription to fire early (regression) Jan 9, 2023
This was referenced Jan 9, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(middleware/persist): hydrate in sync (new impl with storage option) pmndrs/zustand
1 participant
@meypod