Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools broken #72

Closed
joelmoss opened this issue Oct 28, 2019 · 4 comments
Closed

devtools broken #72

joelmoss opened this issue Oct 28, 2019 · 4 comments

Comments

@joelmoss
Copy link

Using 2.2.0 and the devtools middleware is broken due to an incorrect guard going from this to this

You now have this...

!initialState.dispatch && ignoreState && 'setState'

when it should be this...

!initialState.dispatch && !ignoreState && 'setState'
@drcmda
Copy link
Member

drcmda commented Oct 29, 2019 •
edited

must've happened by accident, will flip it. @JeremyRH or was this intentional? can't remember the exact internals right now.

@JeremyRH
Copy link
Contributor

I think it was an accident. Sorry about that.

@drcmda drcmda closed this as completed in f87534e Oct 30, 2019
@drcmda
Copy link
Member

drcmda commented Oct 30, 2019

i published a patch

@joelmoss
Copy link
Author

thx guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joelmoss @drcmda @JeremyRH