useStore stops firing on state changes after component remounts

[karlpetersson]

When switching between mounting two components that both calls the useStore hook, where one of them conditionally mounts a child that also calls useStore, the parent will stop rendering on state changes after remounting. Here's a minimal example on codesandbox:

https://codesandbox.io/s/nostalgic-hooks-0x63r

Repro steps are included. Let me know if you want the code pasted here instead.

Could this be related to #85 ?

edit: updated codesandbox link, messed around in the original one I posted without realizing it.

[karlpetersson]

Downgrading to 2.2.1 seems to fix this issue. Tested by downgrading the zustand package in the above codesandbox.

[karlpetersson]

Dug in a little and it seems that subscribers are indeed being overwritten like in #84, in this case the child gets assigned same index as its parent.

What about compressing the subscribers array right after adding a subscriber? This seems to solve this issue as well as work with #84, while keeping order/indices intact. E.g: Below does not work as is.

const subscribe: Subscribe<TState> = <StateSlice>(
    subscriber: Subscriber<TState, StateSlice>
  ) => {
    // ...
    subscribers[subscriber.index] = subscriber;

    subscriberCount = 0;
    subscribers = subscribers.filter(s => {
      subscriber.index = subscriberCount++;
      return true;
    });

    return () => delete subscribers[subscriber.index];
  };

[Jamikk]

I have the same problem

[fzkirablackwhy]

me too

[kasaley]

me too! HELP ZUSTAND TEAM

[dentrado]

Any news on this? Seems to still be a problem

[kasaley]

@dentrado On version 2.2.1, everything is fine

[dentrado]

But then I get the bug they fixed in 2.2.2 instead

[kasaley]

@dentrado very sadly (