Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox Gallery Plugin does not appear to work #12

Closed
Zardrastra opened this issue Jan 31, 2023 · 9 comments
Closed

Lightbox Gallery Plugin does not appear to work #12

Zardrastra opened this issue Jan 31, 2023 · 9 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Zardrastra
Copy link

Zardrastra commented Jan 31, 2023

I have been attempting to embed light boxes in blogs using this theme.

When clicking on a light box the box appears to load under the bottom of the page aligned to the left with three blank photos under the image.

I have added the image as a Lightbox by using the following markup:

![MountainBike](MountainBike.jpeg?lightbox=1024&cropResize=200,200)

Specifically I am using the following plugin:
https://getgrav.org/premium/lightbox-gallery

But I have also tested this with featherlight:
https://github.com/getgrav/grav-plugin-featherlight

@pmoreno-rodriguez pmoreno-rodriguez self-assigned this Jan 31, 2023
@pmoreno-rodriguez pmoreno-rodriguez added the bug Something isn't working label Jan 31, 2023
@pmoreno-rodriguez
Copy link
Owner

HI @Zardrastra.

The editorial theme seems to have some incompatibility with certain galleries js libraries.

I'll try to find a solution with the author of the original HTML5Up theme.

@pmoreno-rodriguez pmoreno-rodriguez added the help wanted Extra attention is needed label Feb 1, 2023
@pmoreno-rodriguez
Copy link
Owner

Hi @Zardrastra.

Try changing the base.html.twig from develop branch with Shortcode Gallery, which use the Glightbox JS library, the same one used by Lightbox Gallery Plugin.

I've been testing with this plugin and it works fine with Editorial Theme.

@pmoreno-rodriguez
Copy link
Owner

Can you visit the Editorial Theme demo site?

I've uploaded two new pages, the first one with the Shortcode Gallery plugin and the other one with my Gallery (a new feature for the nex version)

It seems that work fine with the base.html.twig modification.

@Zardrastra
Copy link
Author

Zardrastra commented Feb 1, 2023 via email

@Zardrastra
Copy link
Author

Can you clarify what edits I need to make to the base.html.twig file? I don't quite follow.

@pmoreno-rodriguez
Copy link
Owner

Look at the changes made to the file, via Github. 48c7184

Don't pay too much attention to the comment I put for this review, it says "Update Changelog.md", it's wrong.

@Zardrastra
Copy link
Author

Making those changes to the base.html.twig file resolved the light box issue, I tested this with the Lightbox Gallery plugin.

@pmoreno-rodriguez
Copy link
Owner

Ok. Thanks for your help testing the theme?. Can I close this issue?

@Zardrastra
Copy link
Author

Yes of course, thank you once again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants