-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightbox Gallery Plugin does not appear to work #12
Comments
HI @Zardrastra. The editorial theme seems to have some incompatibility with certain galleries js libraries. I'll try to find a solution with the author of the original HTML5Up theme. |
Hi @Zardrastra. Try changing the base.html.twig from develop branch with Shortcode Gallery, which use the Glightbox JS library, the same one used by Lightbox Gallery Plugin. I've been testing with this plugin and it works fine with Editorial Theme. |
Can you visit the Editorial Theme demo site? I've uploaded two new pages, the first one with the Shortcode Gallery plugin and the other one with my Gallery (a new feature for the nex version) It seems that work fine with the base.html.twig modification. |
Hello,
Yes both of these examples are what I was hoping to be able to do.
Both examples work fine. Your Gallery does look to be the better of the two
examples though, can't wait for your next version :)
…On Wed, Feb 1, 2023 at 9:49 PM pmoreno.rodriguez ***@***.***> wrote:
Can you visit the Editorial Theme demo site
<http://editorial.juanvillen.es/>?
I've uploaded two new pages, the first one with the Shortcode Gallery
plugin and the other one with my Gallery (a new feature for the nex version)
It seems that work fine with the base.html.twig modification.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACEVUG4O3UHPEI3KM6AQNHTWVLD5FANCNFSM6AAAAAAULZEO7Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Can you clarify what edits I need to make to the base.html.twig file? I don't quite follow. |
Look at the changes made to the file, via Github. 48c7184 Don't pay too much attention to the comment I put for this review, it says "Update Changelog.md", it's wrong. |
Making those changes to the base.html.twig file resolved the light box issue, I tested this with the Lightbox Gallery plugin. |
Ok. Thanks for your help testing the theme?. Can I close this issue? |
Yes of course, thank you once again! |
I have been attempting to embed light boxes in blogs using this theme.
When clicking on a light box the box appears to load under the bottom of the page aligned to the left with three blank photos under the image.
I have added the image as a Lightbox by using the following markup:
![MountainBike](MountainBike.jpeg?lightbox=1024&cropResize=200,200)
Specifically I am using the following plugin:
https://getgrav.org/premium/lightbox-gallery
But I have also tested this with featherlight:
https://github.com/getgrav/grav-plugin-featherlight
The text was updated successfully, but these errors were encountered: