Unlocking wagons for Demonic races, slight fix for not wendigo check #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argavyon
approved these changes
Jun 7, 2024
| @@ -161,7 +161,7 @@ const techs = { | |||
| era: 'civilized', | |||
| reqs: { transport: 1 }, | |||
| condition(){ | |||
| return global.tech['farm'] || global.tech['s_lodge'] || (global.tech['hunting'] && global.tech.hunting >= 2) || (global.race['soul_eater'] && !global.race.species === 'wendigo' && global.tech.housing >= 1 && global.tech.currency >= 1) ? true : false; | |||
| return global.tech['farm'] || global.tech['s_lodge'] || (global.tech['hunting'] && global.tech.hunting >= 2) || (global.race['soul_eater'] && global.race.species !== 'wendigo' && global.tech.housing >= 1 && global.tech.currency >= 1) ? true : false; | |||
There was a problem hiding this comment.
The ternary operator at the end seems unnecessary.
Suggested change
| return global.tech['farm'] || global.tech['s_lodge'] || (global.tech['hunting'] && global.tech.hunting >= 2) || (global.race['soul_eater'] && global.race.species !== 'wendigo' && global.tech.housing >= 1 && global.tech.currency >= 1) ? true : false; | |
| return global.tech['farm'] || global.tech['s_lodge'] || (global.tech['hunting'] && global.tech.hunting >= 2) || (global.race['soul_eater'] && global.race.species !== 'wendigo' && global.tech.housing >= 1 && global.tech.currency >= 1); |
There was a problem hiding this comment.
I'm inclined to agree, though there are many other tech conditions using the ternary operator in the exact same manner. For example, the governor tech condition:
return global.genes['governor'] && global.civic.govern.type !== 'anarchy' ? true : false;
Seems odd to only clean up this instance of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1075 attempted to fix #1063 by adding a demonic-specific alt unlock for the wagon tech. This did not actually fix the problem because the not wendigo check
!global.race.species === 'wendigo'is always false due to the not operator being applied toglobal.race.speciesinstead of the boolean result. Switching to a strict inequality fixes this and matches the style of other inequality checks in the file.