Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for recent versions of node-sass #24

Closed
wants to merge 1 commit into from

Conversation

chrislopresto
Copy link

This commit contains the relevant subset of changes from
mpalpha@79a8393

Using the latest master commit for node-sass sass/node-sass@11c96ee, I was not getting any CSS output for any SCSS @import, .json or otherwise.

I noticed mpalpha@79a8393 was returning done({ file: url }) instead of sass.NULL. I am not sure why, seeing as the node-sass importer docs say to return NULL in this instance, but I can verify that making this change solved my problem. All imports – SCSS partials and json – are working now.

I also needed to follow suit and remove dist/ from the .gitignore and both /src and /test from the .npmignore to successfully install with npm 3.

For reference, I am using:

This commit contains the relevant subset of changes from
mpalpha@79a8393
@pmowrer
Copy link
Owner

pmowrer commented Feb 29, 2016

@chrislopresto Sorry, but I can't break from node-sass custom importer guidelines in order to possibly solve your edge case; it may break the importer for other users. If you could provide tests and/or example projects that clearly demonstrate the issue we can revisit.

That said, there's been a lot of confusion and problems around sass.NULL. Perhaps the following threads will help:

sass/node-sass#1356
sass/node-sass#1291

@pmowrer pmowrer closed this Feb 29, 2016
@chrislopresto
Copy link
Author

No problem at all. sass/node-sass#1291 sounds like the root cause.

I am packaging node-sass-json-importer as part of an Ember addon that relies on ember-cli-sass, which pulls in node-sass. I'll see if forking ember-cli-sass to use node-sass@beta does the trick.

I'll let you know if that does the trick. Worst case I'll just use my fork until the dust settles.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants