Fixed NaN bug when min/max is same value.

pmowrer · Oct 7, 2012 · 83e88d5 · 83e88d5
1 parent b9ad54d
commit 83e88d5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/implementation/src/com/patrickmowrer/components/supportClasses/ValueRange.as b/implementation/src/com/patrickmowrer/components/supportClasses/ValueRange.as
@@ -100,7 +100,9 @@ package com.patrickmowrer.components.supportClasses
 
         public function getNearestValidRatioFromValue(value:Number):Number
         {
-            return (getNearestValidValueTo(value) - minimum) / boundsDelta;
+            var divisor:Number = boundsDelta == 0 ? 1 : boundsDelta;
+
+            return (getNearestValidValueTo(value) - minimum) / divisor;
         }
 
         public function getNearestValidValueTo(value:Number):Number

diff --git a/test/src/com/patrickmowrer/components/test/ValueRangeTest.as b/test/src/com/patrickmowrer/components/test/ValueRangeTest.as
@@ -111,5 +111,14 @@ package com.patrickmowrer.components.test
             assertThat(valueRange.roundToNearestGreaterInterval(7), equalTo(7));
             assertThat(valueRange.roundToNearestGreaterInterval(-3.999999), equalTo(-1));        
         }
+
+        [Test]
+        public function returnsValidRatioWhenMinAndMaxAreSameNumber():void
+        {
+            valueRange.minimum = 100;
+            valueRange.maximum = 100;
+
+            assertThat(valueRange.getNearestValidRatioFromValue(100), equalTo(0));
+        }
     }
 }