Make pmp and pmp_vis usable as a git submodule / cmake subdirectory #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced all
include_directories
calls in the cmake files withtarget_include_directories
so that the targets can properly be used with cmakeadd_subdirectory
and properly propagate include directories. This allows to you add pmp as a git submodule to your project. I tested my changes onosx
,Ubuntu 22.04
andWindows 11
for both local and install builds.Motivation
Because using pmp as a git submodule/cmake subdirectory makes it a lot more versatile.
Benefits
See above.
Drawbacks
N/A
Applicable Issues
N/A