Lzma Uncompression fails with "Memory usage limit was reached"

[pmqs]

Seeing a number of cpantesters failures where the common denominator is the lzma error message Memory usage limit was reached

Below is a typical failure

PERL_DL_NONLAZY=1 "/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.30.0/ac75/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/000prereq.t ......... ok
t/001main.t ........... ok

#     Failed test (t/010main-unzip.t at line 385)
#          got: ''
#     expected: 'abcd1'

#     Failed test (t/010main-unzip.t at line 411)
#          got: undef
#     expected: '5'

#     Failed test (t/010main-unzip.t at line 412)
#          got: '0'
#     expected: '5'
# Uncompression Error: Memory usage limit was reached

[pmqs]

Some discussion on memory usage at the XZ Utils forum here

[pmqs]

This code leaks memory

use strict ;
use warnings ;

use Archive::Zip::SimpleZip qw(:all) ;
use Archive::Zip::SimpleUnzip ;

my $zipfile;
my $zip = new Archive::Zip::SimpleZip \$zipfile, Method =>ZIP_CM_LZMA 
    or die "xxx\n" ;

$zip->addString("hello workld", Name => "fred");
$zip->addString("hello workld", Name => "joe");
$zip->close();

my $unzip = new Archive::Zip::SimpleUnzip(\$zipfile)
    or die "Cannot opwen\n" ;

while (1)
{
    my $x = $unzip->content("joe");
    my $y = $unzip->content("fred");
}

[pmqs]

Valgrind sees a leak

==15500== 213,808 bytes in 1,909 blocks are definitely lost in loss record 2,403 of 2,408
==15500==    at 0x483874F: malloc (vg_replace_malloc.c:299)
==15500==    by 0x6BDB096: lzma_lzma_props_decode (lzma_decoder.c:1042)
==15500==    by 0x6BBBE45: setupFilters (in /media/paul/Linux-Shared/base/perl/ext/Gzip/blib/arch/auto/Compress/Raw/Lzma/Lzma.so)
==15500==    by 0x6BBC08C: XS_Compress__Raw__Lzma_lzma_raw_decoder (in /media/paul/Linux-Shared/base/perl/ext/Gzip/blib/arch/auto/Compress/Raw/Lzma/Lzma.so)
==15500==    by 0x4B5887: Perl_pp_entersub (in /media/paul/Linux-Shared/base/perl/install/bin/perl)
==15500==    by 0x4AE2C2: Perl_runops_standard (in /media/paul/Linux-Shared/base/perl/install/bin/perl)
==15500==    by 0x441EE5: perl_run (in /media/paul/Linux-Shared/base/perl/install/bin/perl)
==15500==    by 0x41F9F4: main (in /media/paul/Linux-Shared/base/perl/install/bin/perl)

[pmqs]

The libarchive library includes a change that covers the same leak. See libarchive/libarchive@8c0c4fd

The change in libarchive involves explicitly freeing the options data structure

	ret = lzma_raw_decoder(&(state->stream), filters);
#if LZMA_VERSION < 50010000
	free(filters[0].options);
#endif

[pmqs]

Issue reported upstream to the liblzma library https://sourceforge.net/p/lzmautils/discussion/708858/thread/53c6321fc4/

[pmqs]

Fixed by 05c0eac and b020045

Fixed included in 2.090