Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test for directory entries #19

Closed
pmqs opened this issue Apr 17, 2024 · 1 comment
Closed

Add more test for directory entries #19

pmqs opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pmqs
Copy link
Owner

pmqs commented Apr 17, 2024

  • Check for trailing "/" when External Attributes has directory flag(s) set.
  • Check if directory bit(s) set in External Attributes when training "/" is present.
  • Check that directory entry does not have uncompressed payload (APPNOTE 6.3.10, sec 4.3.8)
  • Check if compressed payload present & uncompresses to zero bytes.
  • Check that Extract Version is set to 2.0 or greater (APPNOTE 6.3.10, sec 4.4.3.2)

Notes for behaviour of unzip executables when dealing with directories without the trailing "/"

  • On Linux Info-ZIP 6.0 will extract it to an empty file
  • On Linux 7z & bsdtar (aka libarchive) extract it as a directory if the Unix bit is set, but not if the only the dos flag is set
@pmqs pmqs added the enhancement New feature or request label Apr 17, 2024
@pmqs pmqs self-assigned this Apr 17, 2024
pmqs added a commit that referenced this issue Apr 17, 2024
    Check for trailing "/" when External Attributes has directory flag(s) set.
    Check if directory bit(s) set in External Attributes when training "/" is present.
    Check that directory entry does not have uncompressed payload (APPNOTE 6.3.10, sec 4.3.8)
    Check if compressed payload present & uncompresses to zero bytes.
    Check that Extract Version is set to 2.0 or greater (APPNOTE 6.3.10, sec 4.4.3.2)
pmqs added a commit that referenced this issue Apr 27, 2024
@pmqs
Copy link
Owner Author

pmqs commented Apr 29, 2024

Done

@pmqs pmqs closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant