Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dead symbols with dark magic #438

Closed
bates64 opened this issue Sep 26, 2021 · 2 comments
Closed

Handle dead symbols with dark magic #438

bates64 opened this issue Sep 26, 2021 · 2 comments
Labels
wontfix This will not be worked on

Comments

@bates64
Copy link
Member

bates64 commented Sep 26, 2021

See also: #432

A few functions, such as func_80242EC4_EA37C4, use a dead version of the libultra sqrtf, but codegen does not match with the typical macro magic we do with dead.h currently. I believe this is because sqrtf is an intrinsic function and gets optimised differently.

If this is the case, there is no way for us to tell the compiler to treat "dead_sqrtf" as if it were the real sqrtf. These functions cannot be matched right now.

My proposed solution is:

  • Use sqrtf in the source code
  • Remove dead.h, compile 'dead' maps normally
  • Perform objcopy dark magic to reroute function X to dead_X
@bates64
Copy link
Member Author

bates64 commented Oct 30, 2022

We fixed dead sqrtf with the wiseguy method right @ethteck? So we don't need this anymore

@bates64 bates64 added the wontfix This will not be worked on label Oct 30, 2022
@ethteck
Copy link
Member

ethteck commented Oct 30, 2022

yeh

@ethteck ethteck closed this as completed Oct 30, 2022
@bates64 bates64 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants