-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSL Script conversion #562
Conversation
|
I'm good with this PR assuming my review comment above is explained and the added warnings - probably due to a lack of EVT_PTR? - are fixed. |
I was able to resolve most warnings I introduced, the rest of the warnings I looked at (not all of them because there are a lot more than 8 for some reasons) seem to be issues that existed before tho? Really confusing, so unless you absolutely need me to resolve those, I'd leave it like this. @nanaian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work. The only thing I'd add is that before anyone does more batch conversion work, please check warnings as you go because I fear there's a warning-causing thing in the new script that's going to end up propagating warnings all across the codebase, so we should try to catch and fix it before we end up doing a ton of these and then having to manually fix each one
Resolves #563
Working towards #368 and #564
Updates
update_evts
anddisasm_script
to function better and have a few QoL improvements.Also do some conversion to the new macro syntax.