Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: github link + gif example #1

Merged
merged 1 commit into from
Nov 16, 2018
Merged

fix: github link + gif example #1

merged 1 commit into from
Nov 16, 2018

Conversation

desaintvincent
Copy link
Collaborator

No description provided.

NilinC
NilinC approved these changes Nov 16, 2018
View reviewed changes
Copy link

@NilinC NilinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

wixyvir
wixyvir requested changes Nov 16, 2018
View reviewed changes
Copy link
Member

@wixyvir wixyvir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every Pull Request MUST be posted in #code-review so everyone can say what they have to say and not only people that you like

package.json Show resolved Hide resolved
bvibrac
bvibrac approved these changes Nov 16, 2018
View reviewed changes
Copy link

@bvibrac bvibrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Proper Readme 👍

kevinbalicot
kevinbalicot approved these changes Nov 16, 2018
View reviewed changes
Copy link

@kevinbalicot kevinbalicot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@desaintvincent desaintvincent merged commit 7106cd6 into master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubianchi jubianchi jubianchi approved these changes

@wixyvir wixyvir wixyvir approved these changes

@kevinbalicot kevinbalicot kevinbalicot approved these changes

@NilinC NilinC NilinC approved these changes

@bvibrac bvibrac bvibrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@desaintvincent @jubianchi @wixyvir @kevinbalicot @NilinC @bvibrac