Skip to content

Commit

Permalink
nfs: fix null checking in nfs_get_option_str()
Browse files Browse the repository at this point in the history
The following null pointer check is broken.

	*option = match_strdup(args);
	return !option;

The pointer `option' must be non-null, and thus `!option' is always false.
Use `!*option' instead.

The bug was introduced in commit c5cb09b ("Cleanup: Factor out some
cut-and-paste code.").

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
xiw authored and Trond Myklebust committed Jan 4, 2013
1 parent 39e88fc commit e25fbe3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfs/super.c
Expand Up @@ -1152,7 +1152,7 @@ static int nfs_get_option_str(substring_t args[], char **option)
{
kfree(*option);
*option = match_strdup(args);
return !option;
return !*option;
}

static int nfs_get_option_ul(substring_t args[], unsigned long *option)
Expand Down

0 comments on commit e25fbe3

Please sign in to comment.