fix: crash on iOS 15 in SwiftySelfAwareHelper
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `CustomSelfAwareHelper ` with direct call to `Wormholy` class. `CustomSelfAwareHelper` crashes on iOS 15 in optimised builds in the "harmlessFunction" which is using objc runtime to iterate through *all* classes and checking for a protocol conformance. There was also a performance concern with this method. Since Wormholy only has one class that conforms to `SelfAware` and this is not public API we are providing to consumers of the library, we don't need a generic solution. It has been replaced with a single direct function call. Removed `WormholyStarterEngine` objc class. constructor attribute static function inside actually had no association with the class. Moved to `wormholy_constructor`. `wormholy_constructor` calls `Wormholy` class directly, instead of indirectly through runtime of `SelfAware`. Removed `SelfAware` protocol. Removed `CustomSelfAwareHelper` struct. Removed `StarterEngine` class.
|
@pmusolino please take in account |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
CustomSelfAwareHelperwith direct call toWormholyclass.CustomSelfAwareHelpercrashes on iOS 15 in optimised builds in the "harmlessFunction" which is using objc runtime to iterate through all classes and checking for a protocol conformance. There was also a performance concern with this method.Since Wormholy only has one class that conforms to
SelfAwareand this is not public API we are providing to consumers of the library, we don't need a generic solution. It has been replaced with a single direct function call.Removed
WormholyStarterEngineobjc class. constructor attribute static function inside actually had no association with the class. Renamed towormholy_constructor.wormholy_constructorcallsWormholyclass directly, instead of indirectly through runtime check ofSelfAwareprotocol.Removed
SelfAwareprotocol.Removed
CustomSelfAwareHelperstruct.Removed
StarterEngineclass.Fixes #103
Fixes #98
Fixes #96