Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customizable detail field to request table view cells #115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add customizable detail field to request table view cells #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/UI/Cells/RequestCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class RequestCell: UICollectionViewCell {
@IBOutlet weak var codeLabel: WHLabel!
@IBOutlet weak var urlLabel: WHLabel!
@IBOutlet weak var durationLabel: WHLabel!
@IBOutlet weak var detailLabel: WHLabel!

func populate(request: RequestModel?){
guard request != nil else {
Expand Down Expand Up @@ -46,5 +47,12 @@ class RequestCell: UICollectionViewCell {
}
urlLabel.text = request?.url
durationLabel.text = request?.duration?.formattedMilliseconds() ?? ""
if let request = request,
let detail = Wormholy.detailProvider?(request) {
detailLabel.text = detail
detailLabel.isHidden = false
} else {
detailLabel.isHidden = true
}
}
}
51 changes: 42 additions & 9 deletions Sources/UI/Cells/RequestCell.xib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="16096" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="20037" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
<device id="retina4_7" orientation="portrait" appearance="light"/>
<dependencies>
<deployment identifier="iOS"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="16087"/>
<plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="20020"/>
<capability name="Safe area layout guides" minToolsVersion="9.0"/>
<capability name="System colors in document resources" minToolsVersion="11.0"/>
<capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
</dependencies>
<objects>
Expand Down Expand Up @@ -60,11 +61,23 @@
<constraint firstAttribute="width" constant="80" id="Sd8-Uy-wXT"/>
</constraints>
</stackView>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="https://jsonplaceholder.typicode.com/wrongURL/" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="70z-Jd-XUy" customClass="WHLabel" customModule="Wormholy" customModuleProvider="target">
<stackView opaque="NO" contentMode="scaleToFill" axis="vertical" distribution="fillProportionally" translatesAutoresizingMaskIntoConstraints="NO" id="zmL-B0-jwg">
<rect key="frame" x="84" y="0.0" width="332" height="130"/>
<fontDescription key="fontDescription" type="system" pointSize="15"/>
<nil key="highlightedColor"/>
</label>
<subviews>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" text="https://jsonplaceholder.typicode.com/wrongURL/" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="zb8-jU-lsg" customClass="WHLabel" customModule="Wormholy" customModuleProvider="target">
<rect key="frame" x="0.0" y="0.0" width="332" height="88.5"/>
<fontDescription key="fontDescription" type="system" pointSize="15"/>
<nil key="textColor"/>
<nil key="highlightedColor"/>
</label>
<label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Some optional header field value" textAlignment="natural" lineBreakMode="tailTruncation" numberOfLines="0" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="eMa-oK-4hI" customClass="WHLabel" customModule="Wormholy" customModuleProvider="target">
<rect key="frame" x="0.0" y="88.5" width="332" height="41.5"/>
<fontDescription key="fontDescription" type="system" pointSize="14"/>
<color key="textColor" white="0.33333333333333331" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
<nil key="highlightedColor"/>
</label>
</subviews>
</stackView>
</subviews>
</stackView>
</subviews>
Expand All @@ -77,22 +90,42 @@
</view>
</subviews>
</view>
<color key="backgroundColor" systemColor="systemBackgroundColor" cocoaTouchSystemColor="whiteColor"/>
<viewLayoutGuide key="safeArea" id="fQB-kE-nuz"/>
<color key="backgroundColor" systemColor="systemBackgroundColor"/>
<constraints>
<constraint firstItem="ifk-de-caS" firstAttribute="top" secondItem="A3c-1c-xAq" secondAttribute="top" constant="8" id="Fr6-Lt-8nW"/>
<constraint firstAttribute="bottom" secondItem="ifk-de-caS" secondAttribute="bottom" constant="8" id="ORE-qq-vpF"/>
<constraint firstAttribute="trailing" secondItem="ifk-de-caS" secondAttribute="trailing" constant="8" id="qjG-xV-mdu"/>
<constraint firstItem="ifk-de-caS" firstAttribute="leading" secondItem="A3c-1c-xAq" secondAttribute="leading" constant="8" id="yPd-8B-Jjl"/>
</constraints>
<viewLayoutGuide key="safeArea" id="fQB-kE-nuz"/>
<size key="customSize" width="432" height="158"/>
<connections>
<outlet property="codeLabel" destination="jmr-Ta-RoN" id="cuG-ij-NN9"/>
<outlet property="detailLabel" destination="eMa-oK-4hI" id="s3S-SW-bVV"/>
<outlet property="durationLabel" destination="Wzf-5k-iHI" id="Pcz-o7-wgo"/>
<outlet property="methodLabel" destination="hvP-NF-g2J" id="reo-m6-Mo0"/>
<outlet property="urlLabel" destination="70z-Jd-XUy" id="7el-vR-YxL"/>
<outlet property="urlLabel" destination="zb8-jU-lsg" id="sGc-j0-Pct"/>
</connections>
<point key="canvasLocation" x="204.80000000000001" y="16.191904047976013"/>
</collectionViewCell>
</objects>
<designables>
<designable name="Wzf-5k-iHI">
<size key="intrinsicContentSize" width="57" height="18"/>
</designable>
<designable name="hvP-NF-g2J">
<size key="intrinsicContentSize" width="66.5" height="18"/>
</designable>
<designable name="jmr-Ta-RoN">
<size key="intrinsicContentSize" width="54" height="30"/>
</designable>
<designable name="zb8-jU-lsg">
<size key="intrinsicContentSize" width="333.5" height="18"/>
</designable>
</designables>
<resources>
<systemColor name="systemBackgroundColor">
<color white="1" alpha="1" colorSpace="custom" customColorSpace="genericGamma22GrayColorSpace"/>
</systemColor>
</resources>
</document>
5 changes: 5 additions & 0 deletions Sources/Wormholy.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ public class Wormholy: NSObject
Wormholy.enable(true)
}
}

/// List screen cell will show additional detail about a request.
/// Can be used for example to show GraphQL operation name.
///
public static var detailProvider: ((RequestModel) -> String?)?

static func enable(_ enable: Bool){
if enable{
Expand Down