Update formatting to make request/responses easier to read #66

colinhumber · 2019-09-17T19:16:02Z

No description provided.

pmusolino

Hi @colinhumber! Thanks for this PR. Everything sounds good, but I don't understand why you replaced the method inside the RequestModelBeautifier.

Paolo

pmusolino · 2019-09-18T14:14:39Z

Sources/Utils/RequestModelBeautifier.swift

+            let jsonData = try? JSONSerialization.data(withJSONObject: object, options: [.prettyPrinted]),
+            let formattedJSON = String(data: jsonData, encoding: .utf8) else { return nil }
+
+        return formattedJSON.replacingOccurrences(of: "\\", with: "")


This is a little bit weird... if a string contains \\ occurrences, you replace it. I'm not sure it's the best way to do it.

Oh good call. I did this a little haphazardly 😬. Just pushed an update that correctly replaces escaped forward slashes (\\/) with a normal slash (/).

- use Courier font when displaying JSON content - use prettyPrinted option with JSONSerializer - remove escaped slashes to allow URLs to render correctly - add link detection to URLs in JSON payloads

colinhumber · 2019-09-18T14:38:10Z

The prettyPrintedJSON method that was there before was generating some incorrect JSON. For example, in the /photos response there were some commas missing.

[
{
  "thumbnailUrl" : "https:\/\/via.placeholder.com\/150\/92c952",
  "url" : "https:\/\/via.placeholder.com\/600\/92c952",
  "title" : "accusamus beatae ad facilis cum similique qui sunt",
  "id" : 1,
  "albumId" : 1
}{ <-- here
  "albumId" : 1,
  "id" : 2,
  "title" : "reprehenderit est deserunt velit ipsam",
  "thumbnailUrl" : "https:\/\/via.placeholder.com\/150\/771796",
  "url" : "https:\/\/via.placeholder.com\/600\/771796"
}{ <-- here
  "id" : 3,
  "url" : "https:\/\/via.placeholder.com\/600\/24f355",
  "albumId" : 1,
  "thumbnailUrl" : "https:\/\/via.placeholder.com\/150\/24f355",
  "title" : "officia porro iure quia iusto qui ipsa ut modi"
}....

I switched it to let the system do the pretty printing as the Dictionary.prettyPrintedJSON was doing.

colinhumber · 2019-09-18T14:39:53Z

@pmusolino Btw thanks for all the work on this library!

pmusolino · 2019-09-18T16:03:30Z

Thank you very much @colinhumber for clarifying this particular!

pmusolino added the enhancement New feature or request label Sep 18, 2019

pmusolino reviewed Sep 18, 2019

View reviewed changes

colinhumber added 2 commits September 18, 2019 08:38

Update formatting to make request/responses easier to read

53a1ae9

- use Courier font when displaying JSON content - use prettyPrinted option with JSONSerializer - remove escaped slashes to allow URLs to render correctly - add link detection to URLs in JSON payloads

Correctly replace escaped forward slashes

18ad6c5

colinhumber force-pushed the formatting branch from 592cec1 to 18ad6c5 Compare September 18, 2019 14:38

pmusolino merged commit 9d174c1 into pmusolino:master Sep 18, 2019

colinhumber deleted the formatting branch September 18, 2019 16:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update formatting to make request/responses easier to read #66

Update formatting to make request/responses easier to read #66

colinhumber commented Sep 17, 2019

pmusolino left a comment

pmusolino Sep 18, 2019

colinhumber Sep 18, 2019 •

edited

colinhumber commented Sep 18, 2019

colinhumber commented Sep 18, 2019

pmusolino commented Sep 18, 2019

Update formatting to make request/responses easier to read #66

Update formatting to make request/responses easier to read #66

Conversation

colinhumber commented Sep 17, 2019

pmusolino left a comment

Choose a reason for hiding this comment

pmusolino Sep 18, 2019

Choose a reason for hiding this comment

colinhumber Sep 18, 2019 • edited

Choose a reason for hiding this comment

colinhumber commented Sep 18, 2019

colinhumber commented Sep 18, 2019

pmusolino commented Sep 18, 2019

colinhumber Sep 18, 2019 •

edited