Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use backports when needed #87

Closed
toddrme2178 opened this issue Feb 12, 2020 · 2 comments
Closed

Only use backports when needed #87

toddrme2178 opened this issue Feb 12, 2020 · 2 comments

Comments

@toddrme2178
Copy link

Currently pmxbot uses several backports packages:

  • backports.method_request
  • backports.unittest_mock
  • importlib-metadata
  • importlib_resources

These are all built-in for more recent versions of python. Would it be possible to only pull these in for versions of python that really need them, rather than depending on them even when they aren't really needed?

For backports.method_request and backports.unittest_mock, these could be eliminated entirely by setting the minimum python version to 3.4 (or 3.5, which many other packages are doing).

@jaraco
Copy link
Member

jaraco commented Nov 14, 2020

Sounds good to me. The minimum supported Python version is 3.6, so happy to accept PRs to remove the cruft.

@jaraco
Copy link
Member

jaraco commented May 13, 2021

I've removed reliance on the two backports. modules.

Regarding the importlib backports, I've refreshed the usage on those, so they're still required for Pythons earlier than 3.9 or 3.10, so the backports will be necessary for some time. Therefore, I'm closing this as good enough.

@jaraco jaraco closed this as completed May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants