Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update loop replaced with callbacks #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update loop replaced with callbacks #109

wants to merge 1 commit into from

Conversation

jonny-lerner-lfl
Copy link

The original implementation introduced an update loop that impacts performance with each additional object in the scene.
This proposed callback-oriented approach should alleviate the issue entirely.

hojat-shafiee
hojat-shafiee approved these changes Apr 7, 2024
View reviewed changes
Copy link

@hojat-shafiee hojat-shafiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great changes, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hojat-shafiee hojat-shafiee hojat-shafiee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonny-lerner-lfl @hojat-shafiee