New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.7, download badge, PEP8 compliance/test #126
Conversation
Oh damn, this is fantastic, thank you! I had a Python 3.7 branch 'waiting' for TravisCI. But that does it. And I didn't know about |
Yes PyPi is fine with Markdown as long as the setup.cfg includes the markdown specification. You can still use RST without that specification, but I started using Markdown because PyPi wasn't liking my more complicated RST, but PyPi was fine with the Markdown. |
I added |
Uhm, yeah, that's kinda silly. It doesn't always make sense to ship software with a locked list of dept, especially for libraries.. |
Yes so either way, if it seems silly to have this requirements.txt just delete it. I hope GitHub will improve the scan in the future. |
Ahh sorry for the delay @scivision, I appreciate this cleanup + CI work across operating systems! I was a bit iffy about the |
I will bump the release shortly. |
Hmm.. I got some failures to look at too. Things that passed in the PR, but apparently not on |
The failures were due to another thing (languages fetching from a new translate.google.com). So had to fix that (and also went to a conference, and then got sick post-conference..). Released in gTTS 2.0.2 ! Thanks again for not only your crazy good contribution, @scivision, but this is great reference for future/other projects! 💯 |
Yes I use this general template for over 100 projects. There are some more cleanups possible for testing vis-a-vis tempfile and pytest when I get time. |
sudo
until Travis-CI makes Xenial official released. I have been using this Travis Python 3.7 setup extensively and reliably.setup.cfg
, which has been supported for a couple years and is the modern Python pathway to better Python security via machine-parsable setup files.flake8
Note: Python 3.4 was removed from Travis-CI, but is still tested in AppVeyor. I feel this is acceptable as Python 3.4 is nearing end of life, and 3.4 support has been dropped in 2017 in such popular modules as
pandas
etc.In my contributions to core Python, I see that 3.4 requires increasingly awkward workarounds to support, and commonly 3.4 is lightly tested by the Python developers, as in this pull request.
Python 3.4 is thus still a part of this package, just not as extensively tested, as happens with Python itself.
P.S. recursive auto-PEP8 compliance edits can be done by
autopep8 -i -r .