Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare two pairs of files: Views are not synced after Clear Results #24

Closed
Yaron10 opened this issue Mar 21, 2016 · 8 comments
Closed
Labels

Comments

@Yaron10
Copy link

Yaron10 commented Mar 21, 2016

Hello Pavel,

When multiple Compares are not disabled.

STR:
Open four files.
Place two in the top view and two in the bottom view.
Compare the two files on the left.
Switch to the other two files.
Compare.
Switch back to the files on the left.
Press Clear Results.
Switch to the other two files.

Result:
The views are not synced.

Related: #13

Best regards.

Yaron10 referenced this issue Mar 21, 2016
After compare those were not properly restored because we were first going back to single view
which disabled the sync scroll menu commands and those became unusable.
@pnedev
Copy link
Owner

pnedev commented Mar 22, 2016

Hello Yaron,

Let me first re-enable the multiple compares, things will be different after that.
We'll double check then this test case, thanks.

BR

@pnedev pnedev added the bug label Mar 22, 2016
@Yaron10
Copy link
Author

Yaron10 commented Mar 22, 2016

Hello Pavel,

I think the broader question is what "Clear Results" should do if there are multiple Compares in the active window.

Clear all Compares?
If so, the problem is not that the views are not synced but rather that the diff marks are not cleared.
Also, the user might want to clear only one Compare.

Clear only the visible Compare?
This means that If the user switches to a non-compared file, "Clear Results" should be disabled.

A setting for the preferred behavior?

Another option is not dealing with it and have some Known-Issues.
After all, it's not a professional Compare application. :)

Thanks again for your great work.

Best regards.

@pnedev
Copy link
Owner

pnedev commented Mar 23, 2016

Hello Yaron,

That's the main question indeed.
For now I thought to implement the

Clear only the visible Compare

variant.
We may as well add Clear all compares command.
What's your opinion on this?

BR

@Yaron10
Copy link
Author

Yaron10 commented Mar 23, 2016

Hello Pavel,

We may as well add Clear all compares command.

That would be the best solution. 👍
It seems that implementing this would require a lot of work.
I take my hat off even for suggesting it. :)

Thank you.

Best regards.

@pnedev
Copy link
Owner

pnedev commented Mar 25, 2016

Hello Yaron,

That shouldn't be that difficult after the refactoring.
Let's get there and we'll see.
Thanks for the feedback.

BR

@Yaron10
Copy link
Author

Yaron10 commented Mar 25, 2016

Hello Pavel,

That shouldn't be that difficult after the refactoring.

OK. :)

Thanks for the feedback.

My pleasure.
I'm impressed and even overwhelmed by the amount of work you've already accomplished.
Thank you!

Best regards.

@pnedev
Copy link
Owner

pnedev commented Apr 6, 2016

Fixed in master branch, thanks.

BR

@pnedev pnedev closed this as completed Apr 6, 2016
@Yaron10
Copy link
Author

Yaron10 commented Apr 8, 2016

Great.
Thank you very much.

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants