Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entry 'call' of the output object is that of the internal function #45

Closed
tuxette opened this issue Oct 7, 2020 · 3 comments
Closed
Assignees
Milestone

Comments

@tuxette
Copy link
Collaborator

tuxette commented Oct 7, 2020

Call:
run.adjclust(mat = mat, type = type, h = h)

Cluster method   : adjClust 
Number of objects: 444
@tuxette tuxette added the bug label Oct 7, 2020
@tuxette tuxette self-assigned this Oct 7, 2020
@tuxette tuxette added enhancement and removed bug labels Oct 7, 2020
@tuxette tuxette assigned pneuvial and unassigned tuxette Sep 15, 2022
@tuxette tuxette added this to the now milestone Sep 15, 2022
pneuvial added a commit that referenced this issue Jan 12, 2023
Fix #45 (update 'calls' for 'adjclust.*' methods)
@tuxette
Copy link
Collaborator Author

tuxette commented Jan 12, 2023

I don't think that works: the function name is OK but the arguments are not the one passed to the function but the one passed to the internal function (hence, the name of the variables in the internal function).

@tuxette tuxette reopened this Jan 12, 2023
@pneuvial
Copy link
Owner

Can you give an example where it fails ?
I was not able to find one using adjClust, hicClust, or snpClust. See e.g.

> data(testdata, package = "snpStats")
> fit1 <- snpClust(Autosomes[1:200, 1:5], h = 3, stats = "R.squared")
Note: 1 merges with non increasing heights.
> fit1

Call:
snpClust(Autosomes[1:200, 1:5], h = 3, stats = "R.squared")

Cluster method   : snpClust 
Number of objects: 5 

> fit1$call
snpClust(Autosomes[1:200, 1:5], h = 3, stats = "R.squared")

@tuxette
Copy link
Collaborator Author

tuxette commented Jan 15, 2023

Forget it: it's perfect! Sorry.

@tuxette tuxette closed this as completed Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants