screens4: movie related fixes

- fixed GetFrame() being called outside the rendering thread and subsequent crashes - fixed horizontal stride for non-multiple-of-16-width h.264 videos (Media Foundation, you lying cow!)
png85 · Dec 21, 2012 · b4cb15d · b4cb15d
1 parent 1aa95b8
commit b4cb15d
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 16 deletions.
diff --git a/altona_wz4/wz4/screens4/movieplayer_win7.cpp b/altona_wz4/wz4/screens4/movieplayer_win7.cpp
@@ -589,6 +589,11 @@ class sMoviePlayerMF : public sMoviePlayer
       // was probably padded to 16 lines (h.264 limitation)
       sInt stride = RawStride?RawStride:Info.XSize;
       sInt extralines = ((size*2/3)/stride)-Info.YSize;
+      if (extralines>0)
+      {
+        stride = sAlign(stride,16); // actually, the stride we get from MF is a lie.
+        extralines = ((size*2/3)/stride)-Info.YSize;
+      }
 
       // copy to y,v,u texture
       sTexture2D *ytex=Mtrl->Texture[0]->CastTex2D();

diff --git a/altona_wz4/wz4/screens4/playlists.cpp b/altona_wz4/wz4/screens4/playlists.cpp
@@ -261,9 +261,28 @@ NewSlideData* PlaylistMgr::OnFrame(sF32 delta, const sChar *doneId, sBool doneHa
   Time += delta;
 
   NewSlideData *nsd = PreparedSlide;
-  PreparedSlide = 0;
+
+  if (nsd && nsd->Type == VIDEO)
+  {
+    // wait for first frame to be fully decoded. must be in rendering thread, thus here.
+    if (nsd->Movie->GetInfo().XSize<0)
+    {
+      nsd->Error = sTRUE;
+      sRelease(nsd->Movie);
+    }
+    else 
+    {
+      sFRect uvr;
+      nsd->Movie->GetFrame(uvr);
+      if (nsd->Movie->GetInfo().XSize==0 || uvr.SizeX()==0)
+        nsd = 0;
+    }
+  }
+
   if (nsd)
   {
+    PreparedSlide = 0;
+
     // prepare auto advance
     if (CurrentDuration>0)
       CurrentSwitchTime = Time;
@@ -794,21 +813,7 @@ void PlaylistMgr::PrepareThreadFunc(sThread *t)
           nsd->Movie = sCreateMoviePlayer(filename,sMOF_DONTSTART|(item->Mute?sMOF_NOSOUND:0));
           if (nsd->Movie)
           {
-            // wait for first frame to be fully decoded
-            sFRect uvr;
-            if (nsd->Movie->GetInfo().XSize<0)
-            {
-              nsd->Error = sTRUE;
-              sRelease(nsd->Movie);
-            }
-            else 
-            {
-              while (nsd->Movie->GetInfo().XSize==0 || uvr.SizeX()==0)
-              {
-                sSleep(5);
-                nsd->Movie->GetFrame(uvr);
-              }
-            }
+
           }
           else
           {