Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming convention in contrib/testpngs/crashers/* #172

Closed
cecabert opened this issue Aug 11, 2017 · 3 comments
Closed

Naming convention in contrib/testpngs/crashers/* #172

cecabert opened this issue Aug 11, 2017 · 3 comments

Comments

@cecabert
Copy link

On OSX, after a fresh clone of the repo, you will end up with changes even though you have not touch anything yet. After some digging it appears that some files have the same names since the file system is case insensitive (SO). The files are listed below:

  • contrib/testpngs/crashers/huge_juNK_chunk.png
  • contrib/testpngs/crashers/huge_juNk_chunk.png

This might lead to error, when cloned automatically from build script (i.e. CMake's ExternalProjects)

Christophe
@glennrp
Copy link
Contributor

glennrp commented Aug 11, 2017

I will rename one of them, but that's too bad because the names "juNK" and "jUNk" are significantly different to PNG; the case of the chunkname bytes is used to distinguish between various types of chunks.

glennrp pushed a commit that referenced this issue Aug 11, 2017
[libpng16] Renamed chunks in contrib/testpngs/crashers to avoid havin…
d19e8b9 
…g files

whose names differ only in case; this causes problems with some platforms
(github issue #172).
@glennrp
Copy link
Contributor

glennrp commented Aug 11, 2017

See commit d19e8b9

@cecabert
Copy link
Author

Thanks for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glennrp @cecabert