Reject invalid chunk types #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chunk types must be ASCII letters, [according to the PNG spec][0]: > Each byte of a chunk type is restricted to the decimal values 65 to 90 > and 97 to 122. These correspond to the uppercase and lowercase ISO 646 > letters (A-Z and a-z) respectively... [libpng has a check for this][1], but pngjs does not before this commit. [0]: https://www.w3.org/TR/png/#5Chunk-layout [1]: https://sourceforge.net/p/libpng/code/ci/e519af8b49f52c4ac400f50f23b48ebe36a5f4df/tree/pngrutil.c#l3145
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 82.52% 82.58% +0.05%
==========================================
Files 22 22
Lines 1202 1206 +4
==========================================
+ Hits 992 996 +4
Misses 210 210
☔ View full report in Codecov by Sentry. |
|
I think in most cases this results in a better error on a corrupted file so I am in favor and don’t count it as breaking. |
lukeapage
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunk types must be ASCII letters, according to the PNG spec:
libpng has a check for this, but pngjs does not before this commit.
This is arguably a breaking change or something you don't want to include, so feel free to reject.