Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import errors #47

Merged
merged 1 commit into from Apr 27, 2022
Merged

Fix import errors #47

merged 1 commit into from Apr 27, 2022

Conversation

lassoan
Copy link
Contributor

@lassoan lassoan commented Mar 30, 2022

fixes issues mentioned at #46

fixes issues mentioned at pnlbwh#46
@jamesobutler
Copy link

@tashrifbillah Could you help with the integration of this PR? Thanks!

@tashrifbillah
Copy link
Collaborator

Hi all, I am surprised that the PR notification did not make it to my primary inbox. Rest assured, I shall review it shortly.

@tashrifbillah
Copy link
Collaborator

The changes look good to me. If we merge it today, should we be able to see updates in https://slicer.cdash.org/index.php?project=SlicerPreview tomorrow?

I see the tests are failing across all three of Linux, MAC, and WIN. However, the builds are already successful.

@lassoan
Copy link
Contributor Author

lassoan commented Apr 26, 2022

The changes look good to me. If we merge it today, should we be able to see updates in https://slicer.cdash.org/index.php?project=SlicerPreview tomorrow?

Yes, if you merge it before 10pm today then you'll see the new results on the dashboard tomorrow morning.

@tashrifbillah tashrifbillah merged commit cc78514 into pnlbwh:master Apr 27, 2022
@tashrifbillah
Copy link
Collaborator

Hi Andras, the build looks okay but we still have one and the most important test failing:

Traceback (most recent call last):
  File "/work/Preview/S-0-E-b/DiffusionQC/Test/run_test.py", line 7, in <module>
    from plumbum import local
ModuleNotFoundError: No module named 'plumbum'

The build log confirms that plumbum package was installed but the testing script cannot find it. How should we change the testing infrastructure then:

https://github.com/pnlbwh/SlicerDiffusionQC/blob/master/Test/CMakeLists.txt

and

from plumbum import local

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants