Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse #41

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse #41

merged 5 commits into from
Oct 13, 2023

Conversation

cameronrutherford
Copy link
Contributor

With the additional GitHub action we should be able to reproduce issue identified in xSDK testing, so we can add a fix that is verifiable in local pipelines.

Closes:

xSDK issues:

@cameronrutherford cameronrutherford added this to the 1.6.0 Release milestone Oct 12, 2023
@cameronrutherford cameronrutherford linked an issue Oct 12, 2023 that may be closed by this pull request
exago+hiop+raja~ipopt ^hiop+raja~sparse fails to build #40
Closed
@cameronrutherford
Copy link
Contributor Author

Added hiop+sparse initially, which both doesn't work in GitHub actions, and doesn't repro the issue... Re-trying with the correct build

@cameronrutherford
Copy link
Contributor Author

I re-produced #18... Going to add build with MPI and try to repro original issue #40

@cameronrutherford
Copy link
Contributor Author

Successfully reproduced the issue. Just need to write the fix

@cameronrutherford cameronrutherford marked this pull request as ready for review October 13, 2023 15:29
@cameronrutherford
Copy link
Contributor Author

@wperkins and @abhyshr please review and make sure I am #ifdef guarding the right things here. If GitHub actions (and other pipelines) pass then we are good to merge and close the xSDK bug.

@cameronrutherford cameronrutherford changed the title Add CPU build with hiop+sparse and exago~ipopt+hiop+raja Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse Oct 13, 2023
wperkins
wperkins approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@wperkins wperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me.

@cameronrutherford cameronrutherford merged commit 9c59814 into develop Oct 13, 2023
11 checks passed
bjpalmer pushed a commit that referenced this pull request Oct 16, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
9defb38 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
This was referenced Oct 18, 2023
Closed
Closed
cameronrutherford added a commit that referenced this pull request Oct 25, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
9dae838 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
bjpalmer pushed a commit that referenced this pull request Oct 30, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
fc2cf0d 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
bjpalmer pushed a commit that referenced this pull request Nov 9, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
ede2de7 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
bjpalmer pushed a commit that referenced this pull request Nov 20, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
514446b 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
cameronrutherford added a commit that referenced this pull request Nov 28, 2023
@cameronrutherford
Add Spack CPU build with exago+hiop+raja~ipopt ^hiop+raja~sparse (#41)
fe75815 
* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef
cameronrutherford added a commit that referenced this pull request Nov 29, 2023
@bjpalmer @jaelynlitz
@nkoukpaizan @cameronrutherford @wperkins
Cleanup testing output on multiple mpi ranks (#24)
f19b82f 
* only print error messages if mpi rank is 0

* add rank check for num ranks

* have non-zero ranks exit gracefully when throwing exago error

* pflow functionality tests fully mpi aware

* add logging rank variable

* Apply pre-commmit fixes

* Deleted unused header file.

* Brought SCOPFLOW test driver in line with PFLOW driver.

* Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW
to adapt tests for running on multiple MPI ranks.

* Apply pre-commmit fixes

* Initialized some variables that were not getting properly set for serial
test case.

* only print error messages if mpi rank is 0

* pflow functionality tests fully mpi aware

* add logging rank variable

* Apply pre-commmit fixes

* Deleted unused header file.

* Brought SCOPFLOW test driver in line with PFLOW driver.

* Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW
to adapt tests for running on multiple MPI ranks.

* Apply pre-commmit fixes

* Update summit modules (#21)

* Minor fix for Summit build system

* Fix '--nnodes'-->'-nodes' on Summit

* Attempt to update Summit modules

* Reinstall Ginkgo and python dependencies on Summit

* Enforce cuda@11.4.2 on Summit

* Specify RelWithDebInfo for ExaGO and HiOp on Summit

* Update Spack

* Relax constraints on exago dependencies on Summit

* Add constraints on HiOp in the spack config. Part of the ExaGO package was conflicting with building HiOp in release mode.

* Cleaner module install on Summit

* Update spack_cpu_build.yaml to work without fork

* Update .github/workflows/spack_cpu_build.yaml

* Update Spack

* Try updating pybind11 submodule to see if it fixes errors with exago+python builds

---------

Co-authored-by: Cameron Rutherford <robert.rutherford@pnnl.gov>

* OPFLOW with RAJA/HIOP sparse GPU solvers (#8)

* OPFLOW: initial implementation of RAJA/HiOp sparse GPU-based solver

WIP - HIOP Sparse solver with GPU model

OPFLOW: Started work on support for HIOP sparse solver interface for GPUs.

Added a copy of hiop sparse solver interface.

OPFLOW: Added model skeleton for GPU sparse version (copying from pbpolrajahiop)

Fixed build

Did some copy paste to add a test for HIOPSPARSE. This test is not actually
functional yet.

Started updating the hiopsparse model and solver code.

More work on updating the solver and model

Added scalar and vector unit tests for model to be used with HIOP sparse solver on GPU

Apply cmake lint

Fix unit tests.

Set the size of array when using Umpire memset.

Code formatting

Some minor changes to get PBPOLRAJAHIOPSPARSE model code to compile

Separate BUS/LINE/GEN/.../Param structs into reusable module

Minor edit

Rename files

Fix typo

Use BUS/LINE/GEN/.../Param structs in Raja HiOp Sparse model (compiles)

Updating HIOP sparse solver GPU API

Completed bounds kernels

Completed scalar and vector functions

WIP - HIOP Sparse solver with GPU model

OPFLOW: Started work on support for HIOP sparse solver interface for GPUs.

Added a copy of hiop sparse solver interface.

OPFLOW: Added model skeleton for GPU sparse version (copying from pbpolrajahiop)

Fixed build

Did some copy paste to add a test for HIOPSPARSE. This test is not actually
functional yet.

Started updating the hiopsparse model and solver code.

More work on updating the solver and model

Added scalar and vector unit tests for model to be used with HIOP sparse solver on GPU

Apply cmake lint

Fix unit tests.

Set the size of array when using Umpire memset.

Code formatting

Rename files

Use BUS/LINE/GEN/.../Param structs in Raja HiOp Sparse model (compiles)

Updating HIOP sparse solver GPU API

Completed bounds kernels

Jacobian and Hessian for sparse model (CPU --> GPU copy)

Use correct array lengths in Eq. Jacobian

Fix bug in Jacobian.

Fix unused variable/parameter errors

OPFLOW: rework solution callback for RAJA/HIOP GPU-based solver

Formatting changes

* Add unit test for RAJA/HiOp Sparse GPU model (9-bus only)

* Apply pre-commmit fixes

* Add test for 200-bus case

* Apply pre-commmit fixes

---------

Co-authored-by: Abhyankar, Shrirang G <shrirang.abhyankar@pnnl.gov>

* Upgrade ascent build system and use `hiop@1.0.0` on CI platforms (#20)

* Boilerplate scripts to install modules on Ascent via submodule Spack

* Fix '--nnodes'-->'-nodes' on Ascent

* Improve Ascent env.sh

* magma@2.6.2 on Ascent

* Apply pre-commmit fixes

* Relax constraints on exago dependencies on Ascent and build ~python

* concretizer: reuse was causing several packages to be duplicated in the environment. Require clean concretizations on  Ascent.

* Minor module update on Ascent

* Add LAPACK_LIBRARIES to Ascent base script. CMAKE was picking up python's openblas otherwise.

* Error with unzip.

* Apply pre-commmit fixes

* Add working build on ascent.

* Add working gcc11.2.0 spack spec.

* Add Ascent Spack pipeline. [ascent-rebuild]

* Update gcc version to 11.2.0 in base.sh [skip-ci]

* Fix stages of Ascent pipeline [ascent-rebuild]

* Add working ascent spack build.

* Add hiop@develop force rebuild to PNNL CI [ascent-rebuild] [newell-rebuild] [deception-rebuild] [incline-rebuild].

* Update Ascent spack built tcl modules

* Only test ascent on tcl module update [ci-skip]

* Update base.sh to disable python on ascent [skip ci]

* Remove LAPACK_LIBRARIES spec [ascent-test]

* Update ascent.gitlab-ci.yml to fix needs/dependencies [ascent-test]

* Update deception spack built tcl modules - [deception-test]

* Try again with Python, but have Spack build it instead of using the external module [ascent-rebuild]

* Force python rebuild on ascent and use hiop@0.7.2 on incline [ascent-rebuild] [newell-rebuild] [incline-rebuild]

* Pin hiop@1.0.0 on all CI platforms [decetpion-rebuild] [ascent-rebuild] [newell-rebuild] [incline-rebuild]

* Fix false positive/negative in Ascent pipelines [deception-rebuild] [ascent-test]

* Update incline spack built tcl modules - [incline-test]

* Update newell spack built tcl modules - [newell-test]

* Fix HiOp spec on Ascent [ascent-rebuild].

* Update deception spack built tcl modules - [deception-test]

* Update CPU Spack build with issue for each failing build [ci skip]

* Update Ascent spack built tcl modules [ascent-test]

* Add 1.0.0 dep into CHANGELOG.

* Add ascent-skip to CI to get tests passing [ascent-test]

---------

Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
Co-authored-by: Cameron Rutherford <robert.rutherford@pnnl.gov>
Co-authored-by: cameronrutherford <cameronrutherford@users.noreply.github.com>
Co-authored-by: spack-auto-module <spack.bot@no-reply.com>

* Add Spack CPU build with `exago+hiop+raja~ipopt ^hiop+raja~sparse` (#41)

* Add CPU build with hiop+sparse and exago~ipopt+hiop+raja

* Update .github/workflows/spack_cpu_build.yaml

* `+mpi` to `+raja` CPU build

* Add HIOPRAJASPARSE model if sparse and raja enabled

* Fix other HIOPRAJASPARSE ifdef

* pflow functionality tests fully mpi aware

* add logging rank variable

* Apply pre-commmit fixes

* Deleted unused header file.

* Brought SCOPFLOW test driver in line with PFLOW driver.

* Applied additional changes to selfcheck.cpp file for PFLOW, SOPFLOW and SCOPFLOW
to adapt tests for running on multiple MPI ranks.

* Apply pre-commmit fixes

* Apply pre-commmit fixes

* Updated third party libraries

* Set more default values in selfcheck.cpp to get rid of uninitialized variables
errors in Valgrind and modified a few test values so that tests pass.

* Apply pre-commmit fixes

* Fixed up some preprocessor glitches that got introduced in the rebase.

* Modified versions on pybind11 and spack to match develop.

* Fix remaining issues in merge request.

* Apply pre-commmit fixes

* Fixed preprocessor directives to match develop branch.

* Modified constructor of FunctionalityTestContext to get rid of a bunch of code
checking MPI calls.

* Apply pre-commmit fixes

* Remove logging ranks variable.

---------

Co-authored-by: Jaelyn Litzinger <jaelyn.litzinger@pnnl.gov>
Co-authored-by: Bruce J Palmer <d3g293@deception04.pnl.gov>
Co-authored-by: Nicholson Koukpaizan <72402802+nkoukpaizan@users.noreply.github.com>
Co-authored-by: Cameron Rutherford <robert.rutherford@pnnl.gov>
Co-authored-by: Bill <wperkins@users.noreply.github.com>
Co-authored-by: Abhyankar, Shrirang G <shrirang.abhyankar@pnnl.gov>
Co-authored-by: nkoukpaizan <nkoukpaizan@users.noreply.github.com>
Co-authored-by: cameronrutherford <cameronrutherford@users.noreply.github.com>
Co-authored-by: spack-auto-module <spack.bot@no-reply.com>
Co-authored-by: Bruce J Palmer <d3g293@deception03.pnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperkins wperkins wperkins approved these changes

@abhyshr abhyshr Awaiting requested review from abhyshr

Assignees

@cameronrutherford cameronrutherford

Labels
xSDK
Projects
None yet
Milestone
1.6.0 Release
Development

Successfully merging this pull request may close these issues.

exago+hiop+raja~ipopt ^hiop+raja~sparse fails to build
3 participants
@cameronrutherford @wperkins @abhyshr