[joss] Contributor guide should be more specific, and probably shouldn't suggest Rust as the language #144
Comments
szhorvat
changed the title
|
Agreed. Will revise the contributor guide. |
|
Resolved in release 2.14 |
bonicim
added a commit
that referenced
this issue
Apr 1, 2024
Merge in HYP/hypernetx from feature/hyp-367 to develop * commit '89c712bfff824b591422f0e15141bf6d7a36a24b': (108 commits) Fix formatting adding arithmetic for hypergraphs Bug fix: shouldn't require passing position for hyper-edges. Remove nwhy decorator reference Run linter; remove HNX_Paper updated hypergraph code class method constructors Remove references to warn_nwhy deprecation decorator Remove deprecated NetworkX functions Remove unnecessary hypergraph test Fix incidence_store bug; move, update, and fix incidence store tests; Remove EntitySet and tests add incidences reference to access _E HypergraphView removing hypergraph_outline to avoid versioning issues. new code is on hypergraph.py now centrality tutorial 5 is ready to go Updated the tutorials in basic 1,3,4 to work with new code.. moved old hypergraph code into hypergraph_2.0 and set hypergraph to match hypergraph_outline. updated dogsAndcats for testing updated tests to work with new hypergraph code. commented out _by_setsystem tests until they can be upgraded updated collapse in incidence to separate functions for equivalence classes and collapse identical elements. user can now specify keys when collapsing added is_empty to match old behavior Refactor set property ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current contribution guide is quite non-specific and doesn't explain the specificities of contributing to this package. All the links go to generic sources, such as the GitHub documentation. Is there anything particular about contributing to this project that would be useful to mention?
It seems to suggest using Rust as the programming language. Is this a mistake (perhaps a leftover from the original source of this guide, that was missed during editing)?
When I submitted a very minor PR to this project in July (#117), it was mentioned that I should have targeted the
developbranch and that this information will be included in the contributor guide. It's still not mentioned in the current version though.https://github.com/pnnl/HyperNetX/blob/0ed183145155f90dd225da176c047b0b3e1cc1ac/CONTRIBUTING.md
Ref: openjournals/joss-reviews#6016
The text was updated successfully, but these errors were encountered: