RCT/YJ/Updating report file names #1365
Conversation
| ) | ||
|
|
||
| def create_data(self, context, data=None): |
There was a problem hiding this comment.
Deleted since this can be integrated into data_items.
| @@ -1,11 +1,9 @@ | |||
| import json | |||
| from copy import deepcopy | |||
| from datetime import datetime | |||
There was a problem hiding this comment.
Deleted b/c it's not in use.
| fail_line = f"|Fail|{self.ruleset_outcome['All'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['Envelope'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['Lighting'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['Receptacles'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['Transformers'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['HVAC-HotWaterSide'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['HVAC-ChilledWaterSide'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['HVAC-AirSide'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['HVAC-General'][RCTOutcomeLabel.FAILED]}|{self.ruleset_outcome['HVAC-Baseline'][RCTOutcomeLabel.FAILED]}|" | ||
| not_applicable_line = f"|Not Applicable|{self.ruleset_outcome['All'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['Envelope'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['Lighting'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['Receptacles'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['Transformers'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['HVAC-HotWaterSide'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['HVAC-ChilledWaterSide'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['HVAC-AirSide'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['HVAC-General'][RCTOutcomeLabel.NOT_APPLICABLE]}|{self.ruleset_outcome['HVAC-Baseline'][RCTOutcomeLabel.NOT_APPLICABLE]}|" | ||
| undetermined_line = f"|Undetermined (manual review)|{self.ruleset_outcome['All'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['Envelope'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['Lighting'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['Receptacles'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['Transformers'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['HVAC-HotWaterSide'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['HVAC-ChilledWaterSide'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['HVAC-AirSide'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['HVAC-General'][RCTOutcomeLabel.UNDETERMINED]}|{self.ruleset_outcome['HVAC-Baseline'][RCTOutcomeLabel.UNDETERMINED]}|" | ||
| ( |
There was a problem hiding this comment.
This part was simplified with the private function (_generate_line) because as we have more and more sections, it's hard to list all the column values.
| "5": "Envelope", | ||
| "6": "Lighting", | ||
| "10": "HVAC General", |
There was a problem hiding this comment.
@weilixu Both sections 10 and 19 have the same section name. Should we update one of these section names?
There was a problem hiding this comment.
@yunjoonjung-PNNL There are several things happening here. Section 19 and Section 10 are sort of mixed. I know there are some discussions on moving the unmet load hours check to section 10 but we currently put this on hold until everything becomes more stable.
A rule renumbering will be conducted, we just need to wait longer to get everything sort out first.
For now, using HVAC - General for section 19 and HVAC General for section 10.
There was a problem hiding this comment.
Sounds great! I'll move the rules when they are reorganized.
| "5": "Envelope", | ||
| "6": "Lighting", | ||
| "10": "HVAC General", |
There was a problem hiding this comment.
@yunjoonjung-PNNL There are several things happening here. Section 19 and Section 10 are sort of mixed. I know there are some discussions on moving the unmet load hours check to section 10 but we currently put this on hold until everything becomes more stable.
A rule renumbering will be conducted, we just need to wait longer to get everything sort out first.
For now, using HVAC - General for section 19 and HVAC General for section 10.
This PR mainly addresses to save the report name with its class name. Further, the PR addresses a few bug fixes/updates. Thanks!