Skip to content

Commit

Permalink
Some more merge conflict fixes...
Browse files Browse the repository at this point in the history
  • Loading branch information
MathijsVerbeeck committed May 9, 2024
1 parent e8b9d1c commit a4bf019
Show file tree
Hide file tree
Showing 15 changed files with 32 additions and 32 deletions.
10 changes: 5 additions & 5 deletions src/m365/base/PowerAppsCommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ describe('PowerAppsCommand', () => {
before(() => {
sinon.stub(telemetry, 'trackEvent').returns();
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
auth.service.connected = true;
auth.connection.active = true;
});

after(() => {
sinon.restore();
auth.service.connected = false;
auth.connection.active = false;
});

it('returns correct resource', () => {
Expand Down Expand Up @@ -85,8 +85,8 @@ describe('PowerAppsCommand', () => {
it('throws error when trying to use the command using application only permissions', () => {
sinonUtil.restore(accessToken.isAppOnlyAccessToken);
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.service.cloudType = CloudType.Public;
auth.connection.active = true;
auth.connection.cloudType = CloudType.Public;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
10 changes: 5 additions & 5 deletions src/m365/base/PowerAutomateCommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ describe('PowerAutomateCommand', () => {
before(() => {
sinon.stub(telemetry, 'trackEvent').returns();
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
auth.service.connected = true;
auth.connection.active = true;
});

after(() => {
sinon.restore();
auth.service.connected = false;
auth.connection.active = false;
});

it('returns correct resource', () => {
Expand Down Expand Up @@ -85,8 +85,8 @@ describe('PowerAutomateCommand', () => {
it('throws error when trying to use the command using application only permissions', () => {
sinonUtil.restore(accessToken.isAppOnlyAccessToken);
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.service.cloudType = CloudType.Public;
auth.connection.active = true;
auth.connection.cloudType = CloudType.Public;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
4 changes: 2 additions & 2 deletions src/m365/base/PowerBICommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ describe('PowerBICommand', () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down Expand Up @@ -107,7 +107,7 @@ describe('PowerBICommand', () => {
const cmd = new MockCommand();
sinonUtil.restore(accessToken.isAppOnlyAccessToken);
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.connection.active = true;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
2 changes: 1 addition & 1 deletion src/m365/base/PowerBICommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default abstract class PowerBICommand extends Command {
protected initAction(args: CommandArgs, logger: Logger): void {
super.initAction(args, logger);

if (!auth.service.connected) {
if (!auth.connection.active) {
// we fail no login in the base command command class
return;
}
Expand Down
8 changes: 4 additions & 4 deletions src/m365/base/PowerPlatformCommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ describe('PowerPlatformCommand', () => {
before(() => {
sinon.stub(telemetry, 'trackEvent').returns();
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
});

after(() => {
sinon.restore();
auth.service.connected = false;
auth.connection.active = false;
});

it('returns correct bapi resource', () => {
Expand Down Expand Up @@ -84,8 +84,8 @@ describe('PowerPlatformCommand', () => {
it('throws error when trying to use the command using application only permissions', () => {
sinonUtil.restore(accessToken.isAppOnlyAccessToken);
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.service.cloudType = CloudType.Public;
auth.connection.active = true;
auth.connection.cloudType = CloudType.Public;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
8 changes: 4 additions & 4 deletions src/m365/base/ToDoCommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,21 @@ describe('ToDoCommand', () => {

before(() => {
sinon.stub(telemetry, 'trackEvent').returns();
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
auth.service.connected = true;
auth.connection.active = true;
});

after(() => {
sinon.restore();
auth.service.connected = false;
auth.connection.active = false;
});

it('throws error when trying to use the command using application only permissions', () => {
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.connection.active = true;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
4 changes: 2 additions & 2 deletions src/m365/base/VivaEngageCommand.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('VivaEngageCommand', () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down Expand Up @@ -142,7 +142,7 @@ describe('VivaEngageCommand', () => {
const cmd = new MockCommand();
sinonUtil.restore(accessToken.isAppOnlyAccessToken);
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(true);
auth.service.connected = true;
auth.connection.active = true;
assert.throws(() => (cmd as any).initAction({ options: {} }, {}));
});
});
2 changes: 1 addition & 1 deletion src/m365/base/VivaEngageCommand.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default abstract class VivaEngageCommand extends Command {
protected initAction(args: CommandArgs, logger: Logger): void {
super.initAction(args, logger);

if (!auth.service.connected) {
if (!auth.connection.active) {
// we fail no login in the base command command class
return;
}
Expand Down
2 changes: 1 addition & 1 deletion src/m365/pa/commands/app/app-consent-set.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe(commands.APP_CONSENT_SET, () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down
2 changes: 1 addition & 1 deletion src/m365/pa/commands/app/app-export.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ describe(commands.APP_EXPORT, () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down
2 changes: 1 addition & 1 deletion src/m365/pa/commands/app/app-get.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ describe(commands.APP_GET, () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down
2 changes: 1 addition & 1 deletion src/m365/pa/commands/app/app-list.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe(commands.APP_LIST, () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down
2 changes: 1 addition & 1 deletion src/m365/pa/commands/app/app-owner-set.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ describe(commands.APP_OWNER_SET, () => {
sinon.stub(pid, 'getProcessName').returns('');
sinon.stub(session, 'getId').returns('');
sinon.stub(accessToken, 'isAppOnlyAccessToken').returns(false);
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand Down
4 changes: 2 additions & 2 deletions src/utils/accessToken.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import auth from '../Auth.js';
describe('utils/accessToken', () => {

before(() => {
auth.service.accessTokens[auth.defaultResource] = {
auth.connection.accessTokens[auth.defaultResource] = {
expiresOn: 'abc',
accessToken: 'abc'
};
Expand All @@ -21,7 +21,7 @@ describe('utils/accessToken', () => {

after(() => {
sinon.restore();
auth.service.connected = false;
auth.connection.active = false;
});

it('isAppOnlyAccessToken returns undefined when access token is undefined', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/accessToken.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export const accessToken = {
* @throws {string} Will throw an error if the access token is an application-only access token.
*/
ensureDelegatedAccessToken(): void {
const accessToken = auth.service.accessTokens[auth.defaultResource].accessToken;
const accessToken = auth.connection.accessTokens[auth.defaultResource].accessToken;
if (this.isAppOnlyAccessToken(accessToken)) {
throw 'This command does not support application-only permissions.';
}
Expand Down

0 comments on commit a4bf019

Please sign in to comment.