Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: FN022002_SCSS_add_fabric_react incorrectly suggest adding UI Fabric import to all .scss files #1468

Closed
waldekmastykarz opened this issue Apr 9, 2020 · 0 comments
Closed

Bug report: FN022002_SCSS_add_fabric_react incorrectly suggest adding UI Fabric import to all .scss files #1468

waldekmastykarz opened this issue Apr 9, 2020 · 0 comments
Assignees
@waldekmastykarz
Labels
bug work in progress
Milestone
v2.9

Comments

@waldekmastykarz
Copy link
Member

Description

The FN022002_SCSS_add_fabric_react spfx project upgrade rule incorrectly suggests adding import of Office UI Fabric to all .scss files.

Steps to reproduce

  1. Create an SPFx v1.8 project with a React web part
  2. Add another .scss file with some contents
  3. Upgrade project to SPFx v1.10

Expected result

FN022002_SCSS_add_fabric_react is triggered only for files with a reference to OUIF

Actual result

FN022002_SCSS_add_fabric_react is triggered for all .scss files

Environment

CLI v2.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waldekmastykarz waldekmastykarz

Labels
bug work in progress
Projects
None yet
Milestone
v2.9
Development

No branches or pull requests
1 participant
@waldekmastykarz