Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: remove short options from args passed to commands #1992

Closed
waldekmastykarz opened this issue Dec 7, 2020 · 0 comments
Closed

Comments

@waldekmastykarz
Copy link
Member

We should remove short options from args passed to the command.

Rationale

In some commands, we allow using unknown options. Unfortunately, after the recent migration to minimist, both the short option and its resolved equivalent are passed into the command. Historically, we've excluded only the resolved equivalents and not the short options from being added to the request. In the current state, the included shorts lead to request errors. Since we don't use them in our code, we should remove them from the args object passed into the command as well as the catch-all _ property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant