Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command: site apppermission list #2206

Closed
fthorild opened this issue Feb 24, 2021 · 7 comments
Closed

New command: site apppermission list #2206

fthorild opened this issue Feb 24, 2021 · 7 comments

Comments

@fthorild
Copy link
Contributor

fthorild commented Feb 24, 2021

Usage

spo site apppermission list [options]

Description

Lists the AAD applications granted permission to a SharePoint site collection.

Options

Option Description
-u, --siteUrl <siteUrl> The site collection url
-i, --appId [appId] App Id
-n, --appDisplayName [appDisplayName] App display name
-o, --output [output] Output type. json,text. Default text
--verbose Runs command with verbose logging
--debug Runs command with debug logging

Remarks

Pass in appId and/or addDisplayName to filter by that app

Grah api docs

https://docs.microsoft.com/en-us/graph/api/site-list-permissions?view=graph-rest-1.0&tabs=http

Initial spec discussion: #2169

@fthorild fthorild changed the title New command: sites permission list New command: site permission list Feb 25, 2021
@waldekmastykarz
Copy link
Member

Looking at the spec again, I wonder if it won't be confusing with regular user and group permissions you can configure on a site and if we shouldn't disambiguate these commands by adding app to it, like spo site apppermission list. What do you think?

@fthorild
Copy link
Contributor Author

fthorild commented Feb 25, 2021

Oh that is very true - too focused on apps and the new fresh Sites.Selected I guess. What we actually discuss is to retrieve "grantedToIdentities" of type "application". "grantedToIdentities" can also be other things such as user, at least when you fire off /permissions on an item/document.

I have seen no samples where you on sites get back anything but application. Tried it out by sharing the site to an external user which does not show in the response when I do /permissions on the site object.

Bottom line, I am all for changing the noun to apppermission to be on the safe and least confusing side. Let me know and I'll update across the board. Also was my short suggestions OK? -i, --appId and -n, --appDisplayName

@waldekmastykarz
Copy link
Member

Shall we go with spo site apppermission list then? --appId and --appDisplayName are good to make it clear which ID and name we expect

@fthorild
Copy link
Contributor Author

Yes, let's do it 💪👍- I'll update the issues

@fthorild fthorild changed the title New command: site permission list New command: site apppermission list Feb 25, 2021
@waldekmastykarz
Copy link
Member

Let's use -u as the short option for site to align with other commands. Other than that, let's get it in! Thank you for writing the spec! 👏

@fthorild
Copy link
Contributor Author

🙋‍♂️ I'd be happy to give this a go

@waldekmastykarz
Copy link
Member

Awesome! Appreciate your help 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants