m365 file add doesn't handle zero byte file

[melcloud]

Description

New graph API based file upload command doesn't handle empty file correctly

Steps to reproduce

touch test.txt
m365 file add --filePath test.txt --folderUrl "https://<sharepoint>/sites/mySite/Shared Documents"
Error: The Content-Range header is missing or malformed.

Expected result

Can upload file with zero bytes

Actual result

Failed upload. If I looked at the output, the Content-Range header is set to "bytes 0--1/0". This is incorrect

Environment

m3565-beta

[waldekmastykarz]

Good catch and thank you for reporting the issue @melcloud. We'll get on it asap.

[waldekmastykarz]

@melcloud thinking of it, what's the use case for uploading empty files?

[melcloud]

Mainly for testing. But in an environment we don't know whether files have content, it is easier to rely on the cli rather than doing additional file byte size check. It is fine without it, just the logic a bit odd

[waldekmastykarz]

Got it. Thank you for clarifying

[Abderahman88]

For empty files, we need to use another PUT-request.
I made some changes in uploadFile logic and got it working.

@waldekmastykarz Please assign to me and I will make a PR.

[waldekmastykarz]

Awesome! Appreciate your help @Abderahman88 👍

[waldekmastykarz]

We've just released a preview version with the issue fixed. You can try it by installing the preview with npm i -g @pnp/cli-microsoft365@next. Once again thank you for reporting the issue @melcloud and thank you @Abderahman88 for the fix 👏