Microsoft Graph v1.0: teams team list

[garrytrinder]

The teams team list command uses beta endpoints for two requests that can now use v1.0 endpoints.

cli-microsoft365/src/m365/teams/commands/team/team-list.ts

Lines 36 to 38 in 266fd8d

	if (args.options.joined) {
	endpoint = `${this.resource}/beta/me/joinedTeams`;
	}

List joinedTeams: https://docs.microsoft.com/en-us/graph/api/user-list-joinedteams?view=graph-rest-1.0&tabs=http

cli-microsoft365/src/m365/teams/commands/team/team-list.ts

Lines 61 to 67 in 266fd8d

	const requestOptions: any = {
	url: `${this.resource}/beta/teams/${group.id}`,
	headers: {
	accept: 'application/json;odata.metadata=none'
	},
	responseType: 'json'
	};

Get team: https://docs.microsoft.com/en-us/graph/api/team-get?view=graph-rest-1.0&tabs=http

[dips365]

Would like to take this.
Could you please assign to me ?

[waldekmastykarz]

Awesome! Appreciate your help @dips365 👍

[dips365]

@waldekmastykarz

I completed code part with v1.0 to get teams.

return Promise.all(
this.items.filter((e: any) => {
return e.resourceProvisioningOptions.indexOf('Team') > -1;
}).map(
g => this.getTeamFromGroup(g)
)
);

Could you please help me out how can I write test cases for this bunch of code ?

[waldekmastykarz]

One way to go about it would be to mock the GET call with three responses:

1. Return three groups, two of which are related to Teams and one that isn't
2. Return the Team for the first group related to Teams
3. Return the Team for the second group related to Teams
4. For all other cases return an Invalid request error

If the commands completed without error, the code is proven to work (ie. not trying to retrieve information about a group that's not linked to a Team). Does this help?