Microsoft Graph v1.0: ‘teams team list‘

[dips365]

• Fixes 'teams team list ' command. Closes Microsoft Graph v1.0: teams team list #2507

[arjunumenon]

Hey @dips365 - I will have a look into the failing test cases and will update you on the same.

@garrytrinder - Assigning it to myself. Hope you are fine with that.

[arjunumenon]

This test case is failing because, the function in actual resolves JSON object in the original method. In your case, you are returning JSON array and hence it is causing the subsequent method to fail. Rather than you returning JSON array, you can return JSON object and this will work without any issue. So your code may look something like below.

else if ((opts.url as string).startsWith(`https://graph.microsoft.com/v1.0/teams/`)) {
        const id: string = (<string>opts.url).substring((<string>opts.url).lastIndexOf(`/`) + 1);
        return Promise.resolve({
          "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#teams/$entity",
          "id": id,
          "webUrl": "https://teams.microsoft.com/l/team/19:a5c6eccad3fb401997756a1501d561aa%40thread.skype/conversations?groupId=8090c93e-ba7c-433e-9f39-08c7ba07c0b3&tenantId=dcd219dd-bc68-4b9b-bf0b-4a33a796be35",
          "isArchived": false,
          "memberSettings": {
            "allowCreateUpdateChannels": true,
            "allowDeleteChannels": true,
            "allowAddRemoveApps": true,
            "allowCreateUpdateRemoveTabs": true,
            "allowCreateUpdateRemoveConnectors": true
          },
          "guestSettings": {
            "allowCreateUpdateChannels": false,
            "allowDeleteChannels": false
          },
          "messagingSettings": {
            "allowUserEditMessages": false,
            "allowUserDeleteMessages": false,
            "allowOwnerDeleteMessages": false,
            "allowTeamMentions": true,
            "allowChannelMentions": true
          },
          "funSettings": {
            "allowGiphy": true,
            "giphyContentRating": "moderate",
            "allowStickersAndMemes": true,
            "allowCustomMemes": false
          }
        });
      }

Totally understand the confusion for you in this case since you are having multiple promises in the original method. Eventhough promises are multiple, all it returns is a single object and all we need to do is mock it as a Promise.resolve of single JSON object.

Hope it is clear for you now

[arjunumenon]

As per the updated API, the response should have the key resourceProvisioningOptions along with existing properties.

Hence you may have to update the Fake Promise with the update which would be something like below.

        return Promise.resolve({
          "value": [
            {
              "id": "02bd9fd6-8f93-4758-87c3-1fb73740a315",
              "description": "Team 1 description",
              "displayName": "Team 1",
              "resourceProvisioningOptions": ["Team"]
            },
            {
              "id": "13be6971-79db-4f33-9d41-b25589ca25af",
              "description": "Team 2 description",
              "displayName": "Team 2",
              "resourceProvisioningOptions": ["Team"]
            },

Guess you had already done that in the other methods. Might have missed in this particular method. Nothing major.. That happens. 👍

[arjunumenon]

Hello @dips365 - You have already completed most of the test cases. Good job on that👏

For the 2 failing tests, I have updated my comments. Once you update that and initiate PR, test cases along with coverage should work expected. Let me know if you have any questions.

[dips365]

@arjunumenon Thanks for review !! I will update it and let you know if needs any more clarification

[dips365]

@arjunumenon Thanks much !!

[arjunumenon]

It is good that the checks work as expected. Good job @dips365 .

[garrytrinder]

Thank you @dips365 great work! 👏

Manually merged 🚀