Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation]: Out of date asciicinema video on Installing the CLI page #2663

Closed
garrytrinder opened this issue Sep 2, 2021 · 3 comments
Closed

[Documentation]: Out of date asciicinema video on Installing the CLI page #2663

garrytrinder opened this issue Sep 2, 2021 · 3 comments
Assignees
@plamber
Labels
docs help wanted
Milestone
v4.2

Comments

@garrytrinder
Copy link
Member

The asciicinema video on the page displays the installation of @pnp/office365-cli.

image
@waldekmastykarz
Copy link
Member

Ouch, we missed that one 🙁

@michaelmaillot
Copy link
Contributor

I've also seen those o365 / Office 365 CLI oldies mentioned on other User Guide sections:

Maybe a dedicated PR for updating User Guide whole page would be better?

@waldekmastykarz
Copy link
Member

Good catch @michaelmaillot. You're right, we should definitely fix all these broken windows asap.

@plamber plamber self-assigned this Oct 23, 2021
waldekmastykarz pushed a commit that referenced this issue Oct 29, 2021
@plamber @waldekmastykarz
Updates asciinema video on all pages. solves #2663
91b71ac
@waldekmastykarz waldekmastykarz added this to the v4.2 milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamber plamber

Labels
docs help wanted
Projects
None yet
Milestone
v4.2
Development

No branches or pull requests
4 participants
@waldekmastykarz @garrytrinder @plamber @michaelmaillot