Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align aad sp get and aad serviceprincipal get #2771

Closed
waldekmastykarz opened this issue Oct 19, 2021 · 2 comments
Closed

Align aad sp get and aad serviceprincipal get #2771

waldekmastykarz opened this issue Oct 19, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@waldekmastykarz
Copy link
Member

waldekmastykarz commented Oct 19, 2021

Somehow we totally missed it that we already had the aad sp get command to retrieve information about a service principal and introduce a duplicate named aad serviceprincipal get. The only difference between the two commands is that the first is based on AAD Graph and the latter on MS Graph. Since we already had a command, we should remove the duplicate aad serviceprincipal get.

@nanddeepn
Copy link
Contributor

Hi @waldekmastykarz
We do have #2754 for this to use the Microsoft Graph v1.0 endpoint for aad sp get command.

@waldekmastykarz
Copy link
Member Author

Thanks, I've seen it indeed. Before we merge the PR, we need to double check if the command will stay backwards compatible. If that's not the case, we'd need to postpone merging it until the next major version :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants